--===============1478464984== Content-Type: multipart/alternative; boundary="===============4002769716761875287==" --===============4002769716761875287== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100750/#review1698 ----------------------------------------------------------- There's no need to add a UI option for this, the user should just be able t= o set an empty title and the header would then get hidden / collapsed. Right now, this doesn't happen since when the label is empty, the default g= ets chosen. So this mechanism needs to be a bit smarter to detect when the = user has actually set an empty title (which is different from title.isEmpty= () so set default name). - Sebastian On Feb. 26, 2011, 5:13 p.m., Farhad Hedayati Fard wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100750/ > ----------------------------------------------------------- > = > (Updated Feb. 26, 2011, 5:13 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Let the user set a blank label. The label should not take up any space wh= en it is blank. > = > = > Diffs > ----- > = > plasma/applets/folderview/folderview.h 2241b12 = > plasma/applets/folderview/folderview.cpp f604277 = > plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 = > = > Diff: http://git.reviewboard.kde.org/r/100750/diff > = > = > Testing > ------- > = > Works fine here! = > = > = > Screenshots > ----------- > = > folderview configuration dialog > http://git.reviewboard.kde.org/r/100750/s/84/ > folderview with blank label > http://git.reviewboard.kde.org/r/100750/s/85/ > = > = > Thanks, > = > Farhad > = > --===============4002769716761875287== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100750/ 

There'=
s no need to add a UI option for this, the user should just be able to set =
an empty title and the header would then get hidden / collapsed.

Right now, this doesn't happen since when the label is empty, the defau=
lt gets chosen. So this mechanism needs to be a bit smarter to detect when =
the user has actually set an empty title (which is different from title.isE=
mpty() so set default name).

- Sebastian


On February 26th, 2011, 5:13 p.m., Farhad Hedayati Fard wrote:

Review request for Plasma.
By Farhad Hedayati Fard.

Updated Feb. 26, 2011, 5:13 p.m.

Descripti= on 

Let the user set a blank label. The label should not take up=
 any space when it is blank.

Testing <= /h1> 
Works fine here!

Diffs=

  • plasma/applets/folderview/folderview.h (22= 41b12)
  • plasma/applets/folderview/folderview.cpp (= f604277)
  • plasma/applets/folderview/folderviewDisplayConfig.ui (6568640)

View Diff

Screensho= ts

3D"folderview 3D"folderview
--===============4002769716761875287==-- --===============1478464984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1478464984==--