'Review Request: Adding "Set Wallpaper Image" option in Picture frame'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Adding "Set Wallpaper Image" option in Picture frame
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2011-02-27 19:55:32
Message-ID: 20110227195532.17799.60439 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100764/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

Adding "Set Wallpaper Image" feature in Picture Frame. If the User right cl=
icks on Picture Frame, there will be an option "Set Wallpaper Image". This =
Option will set the current Image Of Picture Frame as Wallpaper Image. Done=
 changes according to suggestion given by Todd and Aaron. Continuation of h=
ttp://svn.reviewboard.kde.org/r/6416/.

Diffs
-----

  applets/frame/frame.cpp 871ebef =

  applets/frame/frame.h bf7b95d =

Diff: http://git.reviewboard.kde.org/r/100764/diff

Testing
-------

working fine
Added  QTimer::singleShot(300,this, SLOT(setImageAsWallpaper())); line in f=
rame.cpp because Plugin takes some time to load.
Not sure it is correct way to do or not. Any suggestion?

Thanks,

Sinny

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100764/">http://git.reviewboard.kde.org/r/100764/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding &quot;Set Wallpaper Image&quot; feature in Picture Frame. If the \
User right clicks on Picture Frame, there will be an option &quot;Set Wallpaper \
Image&quot;. This Option will set the current Image Of Picture Frame as Wallpaper \
Image. Done changes according to suggestion given by Todd and Aaron. Continuation of \
http://svn.reviewboard.kde.org/r/6416/.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">working fine Added  QTimer::singleShot(300,this, \
SLOT(setImageAsWallpaper())); line in frame.cpp because Plugin takes some time to \
load. Not sure it is correct way to do or not. Any suggestion?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/frame/frame.cpp <span style="color: grey">(871ebef)</span></li>

 <li>applets/frame/frame.h <span style="color: grey">(bf7b95d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100764/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 