From kde-panel-devel Sun Feb 27 13:56:29 2011 From: "Marco Martin" Date: Sun, 27 Feb 2011 13:56:29 +0000 To: kde-panel-devel Subject: Re: Review Request: focus on search box when the widget explorer is Message-Id: <20110227135629.28606.83339 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129881504032644 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0053180280==" --===============0053180280== Content-Type: multipart/alternative; boundary="===============1167274818200243109==" --===============1167274818200243109== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100757/#review1674 ----------------------------------------------------------- Ship it! thanks, long needed fix. can you backport as well? - Marco On Feb. 26, 2011, 6:38 p.m., Farhad Hedayati Fard wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100757/ > ----------------------------------------------------------- > = > (Updated Feb. 26, 2011, 6:38 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > when the widget explorer is opened, It should get focus (currently it doe= sn't) and the focus should be passed to the search box. > = > = > Diffs > ----- > = > libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h a81b0e6 = > libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp bac2a63 = > plasma/desktop/shell/controllerwindow.cpp b541e98 = > = > Diff: http://git.reviewboard.kde.org/r/100757/diff > = > = > Testing > ------- > = > works as expected. > = > = > Thanks, > = > Farhad > = > --===============1167274818200243109== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100757/

Ship it!

thanks, lo=
ng needed fix.
can you backport as well?

- Marco


On February 26th, 2011, 6:38 p.m., Farhad Hedayati Fard wrote:

Review request for Plasma.
By Farhad Hedayati Fard.

Updated Feb. 26, 2011, 6:38 p.m.

Descripti= on 

when the widget explorer is opened, It should get focus (cur=
rently it doesn't) and the focus should be passed to the search box.

Testing <= /h1> 
works as expected.

Diffs=

  • libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h (a81b0e6)
  • libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp (bac2a63)
  • plasma/desktop/shell/controllerwindow.cpp = (b541e98)

View Diff
--===============1167274818200243109==-- --===============0053180280== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0053180280==--