[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: focus on search box when the widget explorer is opened
From: "Farhad Hedayati Fard" <hf.farhad () gmail ! com>
Date: 2011-02-26 18:38:21
Message-ID: 20110226183821.4818.4839 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100757/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
when the widget explorer is opened, It should get focus (currently it doesn=
't) and the focus should be passed to the search box.
Diffs
-----
libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h a81b0e6 =
libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp bac2a63 =
plasma/desktop/shell/controllerwindow.cpp b541e98 =
Diff: http://git.reviewboard.kde.org/r/100757/diff
Testing
-------
works as expected.
Thanks,
Farhad
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100757/">http://git.reviewboard.kde.org/r/100757/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">when the widget explorer is opened, It should get focus (currently it \
doesn't) and the focus should be passed to the search box.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h <span style="color: \
grey">(a81b0e6)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp <span style="color: \
grey">(bac2a63)</span></li>
<li>plasma/desktop/shell/controllerwindow.cpp <span style="color: \
grey">(b541e98)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100757/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic