--===============0074852972== Content-Type: multipart/alternative; boundary="===============2533876021277242875==" --===============2533876021277242875== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100743/#review1667 ----------------------------------------------------------- hmm i'm not sure about it, i don't see an huge use case of showing icons th= at are meant to be passive (so not telling anything useful at the moment) however the patch is well done (i appreciate disabling the combo boxes when= the always show all option is checked) so hmm, yeah, i'm a bit on the fence on this one but if there aren't other = objections i think it can go in - Marco On Feb. 25, 2011, 4:33 p.m., Jonathan Marten wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100743/ > ----------------------------------------------------------- > = > (Updated Feb. 25, 2011, 4:33 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > If the user wishes to have all system tray items visible at all times, th= ere is no single setting to allow this. The only option is to go to System= Tray Settings - Entries and set all of the "Visibility" combo boxes to "Al= ways Visible", and repeat this whenever a new item appears. > = > All versions of a popular closed source operating system have this option= for the system tray. > = > This change adds a check box "Always show all system tray items" below th= e list on the Entries page. Checking this sets all items (current and any = new ones that may appear in future) to be always visible and disables the "= Visibility" column. It is still possible to access the "Keyboard Shortcut"= column. > = > The default is for this option not to be set, so the system tray operatio= n is the same as before. > = > = > Diffs > ----- > = > plasma/generic/applets/systemtray/ui/applet.h b0e9a55 = > plasma/generic/applets/systemtray/ui/applet.cpp bd2d8ff = > plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff = > plasma/generic/applets/systemtray/ui/taskarea.h 091763c = > plasma/generic/applets/systemtray/ui/taskarea.cpp cfa503b = > = > Diff: http://git.reviewboard.kde.org/r/100743/diff > = > = > Testing > ------- > = > Built kde-workspace with these changes, checked operation of system tray = and settings dialogue with this option checked and not checked. > = > = > Thanks, > = > Jonathan > = > --===============2533876021277242875== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100743/

hmm i'=
m not sure about it, i don't see an huge use case of showing icons that=
 are meant to be passive (so not telling anything useful at the moment)

however the patch is well done (i appreciate disabling the combo boxes when=
 the always show all option is checked)
so hmm, yeah, i'm a bit on the fence on this one but if there aren'=
t other objections i think it can go in

- Marco

On February 25th, 2011, 4:33 p.m., Jonathan Marten wrote:

Review request for Plasma.

By Jonathan Marten.

Updated Feb. 25, 2011, 4:33 p.m.

Descripti= on

If the user wishes to have all system tray items visible at =
all times, there is no single setting to allow this.  The only option is to=
 go to System Tray Settings - Entries and set all of the "Visibility&q=
uot; combo boxes to "Always Visible", and repeat this whenever a =
new item appears.

All versions of a popular closed source operating system have this option f=
or the system tray.

This change adds a check box "Always show all system tray items" =
below the list on the Entries page.  Checking this sets all items (current =
and any new ones that may appear in future) to be always visible and disabl=
es the "Visibility" column.  It is still possible to access the &=
quot;Keyboard Shortcut" column.

The default is for this option not to be set, so the system tray operation =
is the same as before.

Testing <= /h1>

Built kde-workspace with these changes, checked operation of=
 system tray and settings dialogue with this option checked and not checked.

Diffs=

plasma/generic/applets/systemtray/ui/applet.h (b0e9a55)
plasma/generic/applets/systemtray/ui/applet.cpp (bd2d8ff)
plasma/generic/applets/systemtray/ui/autohide.ui (3b6efff)
plasma/generic/applets/systemtray/ui/taskarea.h (091763c)
plasma/generic/applets/systemtray/ui/taskarea.cpp (cfa503b)

--===============2533876021277242875==-- --===============0074852972== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0074852972==--