From kde-panel-devel Sat Feb 26 09:00:06 2011 From: "Sergio Luis Martins" Date: Sat, 26 Feb 2011 09:00:06 +0000 To: kde-panel-devel Subject: Re: Review Request: remove Assert on collection id change Message-Id: <20110226090006.6724.70319 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129871086928213 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0257650855==" --===============0257650855== Content-Type: multipart/alternative; boundary="===============2199575293797490674==" --===============2199575293797490674== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1656 ----------------------------------------------------------- I fixed kdepim/calendarsupport/calendar.cpp. It now handles moves. So someone just needs to copy kdepim/calendarsupport/calendar.cpp to plasma. Please close this review. - Sergio Luis On Feb. 2, 2011, 8:19 a.m., Mario Bensi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100523/ > ----------------------------------------------------------- > = > (Updated Feb. 2, 2011, 8:19 a.m.) > = > = > Review request for KDEPIM and Plasma. > = > = > Summary > ------- > = > Actually, there is an assert when the collection id are not the same you > are store in your cache. I work on Zanshin and I can move an Item from a > Collection to another and i can reproduce the same behaviour with akonadi= console. > = > This path remove the assert on this case and avoid a crash when we move > the item to a different collection. > = > I add kdepim in groups because a part of the code comes from kdepim/akona= di/kcal > = > = > Diffs > ----- > = > plasma/generic/dataengines/calendar/akonadi/calendar.cpp 71e4fe6 = > = > Diff: http://git.reviewboard.kde.org/r/100523/diff > = > = > Testing > ------- > = > = > Thanks, > = > Mario > = > --===============2199575293797490674== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100523/ 

I fixed kd=
epim/calendarsupport/calendar.cpp.

It now handles moves.

So someone just needs to copy kdepim/calendarsupport/calendar.cpp to plasma.

Please close this review.

- Sergio Luis


On February 2nd, 2011, 8:19 a.m., Mario Bensi wrote:

Review request for KDEPIM and Plasma.
By Mario Bensi.

Updated Feb. 2, 2011, 8:19 a.m.

Descripti= on 

Actually, there is an assert when the collection id are not =
the same you
are store in your cache. I work on Zanshin and I can move an Item from a
Collection to another and i can reproduce the same behaviour with akonadico=
nsole.

This path remove the assert on this case and avoid a crash when we move
the item to a different collection.

I add kdepim in groups because a part of the code comes from kdepim/akonadi=
/kcal

Diffs=

  • plasma/generic/dataengines/calendar/akonadi/calendar.cpp (71e4fe6)

View Diff
--===============2199575293797490674==-- --===============0257650855== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0257650855==--