--===============0002439538== Content-Type: multipart/alternative; boundary="===============2255853245472835382==" --===============2255853245472835382== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Feb. 23, 2011, 8:02 p.m., Marco Martin wrote: > > libs/plasmaclock/calendar.cpp, line 212 > > > > > > those ifs can be replaced by a switch, since it's just an enum replace by a switch! > On Feb. 23, 2011, 8:02 p.m., Marco Martin wrote: > > libs/plasmaclock/calendar.cpp, line 219 > > > > > > if isn't used, remove it alltogether ops :D I just forgot to add the code for them here :P they're used to navig= ate one week forward/backward, added the code :) - Farhad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1613 ----------------------------------------------------------- On Feb. 23, 2011, 7:27 p.m., Farhad Hedayati Fard wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100718/ > ----------------------------------------------------------- > = > (Updated Feb. 23, 2011, 7:27 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Added some keyboard shortcuts through "keyPressEvent"s = > Key_Right -> next month > Key_Left -> previous month > Key_Return and Key_Enter -> today > Key_PageUp -> next year > Key_PageDown -> previous year > = > = > This addresses bug https://bugs.kde.org/show_bug.cgi?id=3D249866. > http://bugs.kde.org/show_bug.cgi?id=3Dhttps://bugs.kde.org/show_bug.c= gi?id=3D249866 > = > = > Diffs > ----- > = > libs/plasmaclock/calendar.h f0f1c09 = > libs/plasmaclock/calendar.cpp 57eecd6 = > libs/plasmaclock/clockapplet.h b75f286 = > libs/plasmaclock/clockapplet.cpp e81d549 = > plasma/generic/applets/calendar/calendar.h 94cbe93 = > plasma/generic/applets/calendar/calendar.cpp c83b9ee = > = > Diff: http://git.reviewboard.kde.org/r/100718/diff > = > = > Testing > ------- > = > works fine here! > = > = > Thanks, > = > Farhad > = > --===============2255853245472835382== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100718/

On February 23rd, 2011, 8:02 p.m., Marco Ma= rtin wrote:

= = =
libs/plasmaclock/calendar.cpp (Diff revision 3) 

   
void Calendar::keyPressEvent(QKeyEvent* event)


  

 

  

    
    

    212
    
    if (event->key() =3D=
=3D Qt::Key_Right) {

  


 




  
those ifs=
 can be replaced by a switch, since it's just an enum

 









replace by a switch!






 
On February 23rd, 2011, 8:02 p.m., Marco Ma=
rtin wrote:

 

  =









 =

 =




 

 
  

   
    libs/plasmaclock/calendar.cpp
    

     (Diff revision 3)

    
   
  

 

 
  


   

   
void Calendar::keyPressEvent(QKeyEvent* event)


  

 

  

    
    

    219
    
      

  


 




  
if isn=
9;t used, remove it alltogether

 









ops :D I just forgot to add the code for them here :P they're us=
ed to navigate one week forward/backward, added the code :)








- Farhad






On February 23rd, 2011, 7:27 p.m., Farhad Hedayati Fard wrote:









 

  


Review request for Plasma.


By Farhad Hedayati Fard.




Updated Feb. 23, 2011, 7:27 p.m.






Descripti=
on 



 

  
   
Added some keyboard shortcuts through "keyPressEvent&qu=
ot;s =

Key_Right -> next month
Key_Left -> previous month
Key_Return and Key_Enter -> today
Key_PageUp -> next year
Key_PageDown -> previous year

  		
 






Testing <=
/h1>


 

  
   
works fine here!

  		
 










Diffs=
 


    

 
  • libs/plasmaclock/calendar.h (f0f1c09)
    • 

 
  • libs/plasmaclock/calendar.cpp (57eecd6)
    • 

 
  • libs/plasmaclock/clockapplet.h (b75f286)
    • 

 
  • libs/plasmaclock/clockapplet.cpp (e81d549)=

    • 

 
  • plasma/generic/applets/calendar/calendar.h (94cbe93)
    • 

 
  • plasma/generic/applets/calendar/calendar.cpp (c83b9ee)
    • 





View Diff





  		
 











  

 



--===============2255853245472835382==--

--===============0002439538==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0002439538==--