This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/

On February 23rd, 2011, 8:02 p.m., Marco Martin wrote:

libs/plasmaclock/calendar.cpp (Diff revision 3)
void Calendar::keyPressEvent(QKeyEvent* event)
212
    if (event->key() == Qt::Key_Right) {
those ifs can be replaced by a switch, since it's just an enum
replace by a switch!

On February 23rd, 2011, 8:02 p.m., Marco Martin wrote:

libs/plasmaclock/calendar.cpp (Diff revision 3)
void Calendar::keyPressEvent(QKeyEvent* event)
219
      
if isn't used, remove it alltogether
ops :D I just forgot to add the code for them here :P they're used to navigate one week forward/backward, added the code :)

- Farhad


On February 23rd, 2011, 7:27 p.m., Farhad Hedayati Fard wrote:

Review request for Plasma.
By Farhad Hedayati Fard.

Updated Feb. 23, 2011, 7:27 p.m.

Description

Added some keyboard shortcuts through "keyPressEvent"s 
Key_Right -> next month
Key_Left -> previous month
Key_Return and Key_Enter -> today
Key_PageUp -> next year
Key_PageDown -> previous year

Testing

works fine here!

Diffs

  • libs/plasmaclock/calendar.h (f0f1c09)
  • libs/plasmaclock/calendar.cpp (57eecd6)
  • libs/plasmaclock/clockapplet.h (b75f286)
  • libs/plasmaclock/clockapplet.cpp (e81d549)
  • plasma/generic/applets/calendar/calendar.h (94cbe93)
  • plasma/generic/applets/calendar/calendar.cpp (c83b9ee)

View Diff