'Re: Review Request: Keyboard navigation for calendar applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Keyboard navigation for calendar applet
From:       "Farhad Hedayati Fard" <hf.farhad () gmail ! com>
Date:       2011-02-23 19:27:29
Message-ID: 20110223192729.16175.34463 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100718/
-----------------------------------------------------------

(Updated Feb. 23, 2011, 7:27 p.m.)

Review request for Plasma.

Changes
-------

It's working as expected now, the focusing problem is solved (thanks to Marco) and \
key mappings changed as John suggested :) Let me know if anything else is wrong ;)

Summary
-------

Added some keyboard shortcuts through "keyPressEvent"s 
Key_Right -> next month
Key_Left -> previous month
Key_Return and Key_Enter -> today
Key_PageUp -> next year
Key_PageDown -> previous year

This addresses bug https://bugs.kde.org/show_bug.cgi?id=249866.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866

Diffs (updated)
-----

  libs/plasmaclock/calendar.h f0f1c09 
  libs/plasmaclock/calendar.cpp 57eecd6 
  libs/plasmaclock/clockapplet.h b75f286 
  libs/plasmaclock/clockapplet.cpp e81d549 
  plasma/generic/applets/calendar/calendar.h 94cbe93 
  plasma/generic/applets/calendar/calendar.cpp c83b9ee 

Diff: http://git.reviewboard.kde.org/r/100718/diff

Testing
-------

works fine here!

Thanks,

Farhad

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100718/">http://git.reviewboard.kde.org/r/100718/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>

<p style="color: grey;"><i>Updated Feb. 23, 2011, 7:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s working as expected now, the focusing problem is solved (thanks \
to Marco) and key mappings changed as John suggested :) Let me know if anything else \
is wrong ;) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added some keyboard shortcuts through &quot;keyPressEvent&quot;s  \
Key_Right -&gt; next month Key_Left -&gt; previous month
Key_Return and Key_Enter -&gt; today
Key_PageUp -&gt; next year
Key_PageDown -&gt; previous year</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine here!</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866">https://bugs.kde.org/show_bug.cgi?id=249866</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/plasmaclock/calendar.h <span style="color: grey">(f0f1c09)</span></li>

 <li>libs/plasmaclock/calendar.cpp <span style="color: grey">(57eecd6)</span></li>

 <li>libs/plasmaclock/clockapplet.h <span style="color: grey">(b75f286)</span></li>

 <li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(e81d549)</span></li>

 <li>plasma/generic/applets/calendar/calendar.h <span style="color: \
grey">(94cbe93)</span></li>

 <li>plasma/generic/applets/calendar/calendar.cpp <span style="color: \
grey">(c83b9ee)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100718/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 