[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Keyboard navigation for calendar applet
From: "John Layt" <john () layt ! net>
Date: 2011-02-23 1:36:31
Message-ID: 20110223013631.10365.22074 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100718/#review1601
-----------------------------------------------------------
Just wondering if we want to have navigation for day selection in the date table as \
well? Do we want to make it consistent with the KDatePicker class in kdeui?
KDatePicker has the following key mappings:
Up Arrow = - 1 week (i.e. up one row)
Down Arrow = + 1 week (i.e. down one row)
Left Arrow = - 1 day (i.e. left one column)
Right Arrow = + 1 day (i.e. right one column)
Page Up = - 1 Month
Page Down = + 1 Month
It has no key for +/- year. KDEPIM doesn't have any key-mappings for its date table \
widget.
I think if you have both, then moving the day selected in the day table should be the \
primary navigation, i.e. the arrow keys, with month and year being secondary \
navigation, i.e. Page Up/Down or perhaps Alt-Arrows or Shift-Arrows? I like the Home \
key for Today.
Do we also need key mappings for moving the focus from the date table to the other \
input widgets (Months = Alt-M, Year = Alt-Y, Date = Alt-D, Week = Alt-W) or is \
tabbing enough?
I also think Ctrl-C could copy the currently selected date into the clipboard.
- John
On Feb. 22, 2011, 5:42 p.m., Farhad Hedayati Fard wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100718/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2011, 5:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Added some keyboard shortcuts through "keyPressEvent"s
> Key_Right -> next month
> Key_Left -> previous month
> Key_Return and Key_Enter -> today
> Key_PageUp -> next year
> Key_PageDown -> previous year
>
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=249866.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866
>
>
> Diffs
> -----
>
> libs/plasmaclock/calendar.h f0f1c09
> libs/plasmaclock/calendar.cpp 57eecd6
>
> Diff: http://git.reviewboard.kde.org/r/100718/diff
>
>
> Testing
> -------
>
> works fine here!
>
>
> Thanks,
>
> Farhad
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100718/">http://git.reviewboard.kde.org/r/100718/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just wondering if we \
want to have navigation for day selection in the date table as well? Do we want to \
make it consistent with the KDatePicker class in kdeui?
KDatePicker has the following key mappings:
Up Arrow = - 1 week (i.e. up one row)
Down Arrow = + 1 week (i.e. down one row)
Left Arrow = - 1 day (i.e. left one column)
Right Arrow = + 1 day (i.e. right one column)
Page Up = - 1 Month
Page Down = + 1 Month
It has no key for +/- year. KDEPIM doesn't have any key-mappings for its date \
table widget.
I think if you have both, then moving the day selected in the day table should be the \
primary navigation, i.e. the arrow keys, with month and year being secondary \
navigation, i.e. Page Up/Down or perhaps Alt-Arrows or Shift-Arrows? I like the Home \
key for Today.
Do we also need key mappings for moving the focus from the date table to the other \
input widgets (Months = Alt-M, Year = Alt-Y, Date = Alt-D, Week = Alt-W) or is \
tabbing enough?
I also think Ctrl-C could copy the currently selected date into the clipboard.</pre>
<br />
<p>- John</p>
<br />
<p>On February 22nd, 2011, 5:42 p.m., Farhad Hedayati Fard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2011, 5:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added some keyboard shortcuts through "keyPressEvent"s \
Key_Right -> next month Key_Left -> previous month
Key_Return and Key_Enter -> today
Key_PageUp -> next year
Key_PageDown -> previous year</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine here!</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866">https://bugs.kde.org/show_bug.cgi?id=249866</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/calendar.h <span style="color: grey">(f0f1c09)</span></li>
<li>libs/plasmaclock/calendar.cpp <span style="color: grey">(57eecd6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100718/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic