'Re: Review Request: Timer: one click to pause/resume,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Timer: one click to pause/resume,
From:       "Davide Bettio" <davide.bettio () kdemail ! net>
Date:       2011-02-22 16:56:02
Message-ID: 20110222165602.16667.72349 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100521/#review1584
-----------------------------------------------------------

Please, revert this patch or fix it:
* Currently single click doesn't seem to work
* I don't think double click for reset is a good idea.

- Davide

On Feb. 2, 2011, 9:39 a.m., Rom=C3=A1rio Rios wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100521/
> -----------------------------------------------------------
> =

> (Updated Feb. 2, 2011, 9:39 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> This patch does some little changes to Timer plasmoid:
>  - Now it takes only one click to start, resume and pause it
>  - It now blinks when paused, making it quicker to determine if it's paus=
ed or running
>  - Double-click resets timer
> =

> =

> Diffs
> -----
> =

>   applets/timer/timer.h d191fa3 =

>   applets/timer/timer.cpp a09aa4c =

> =

> Diff: http://git.reviewboard.kde.org/r/100521/diff
> =

> =

> Testing
> -------
> =

> As it's a simple modification, I think that it brings no bugs (except by =
the fact that it says timeout when reseted with double-click).
> =

> =

> Thanks,
> =

> Rom=C3=A1rio
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100521/">http://git.reviewboard.kde.org/r/100521/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please, revert this \
                patch or fix it:
* Currently single click doesn&#39;t seem to work
* I don&#39;t think double click for reset is a good idea.</pre>
 <br />

<p>- Davide</p>

<br />
<p>On February 2nd, 2011, 9:39 a.m., Romário Rios wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>

<p style="color: grey;"><i>Updated Feb. 2, 2011, 9:39 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This patch does some little changes to Timer plasmoid:
 - Now it takes only one click to start, resume and pause it
 - It now blinks when paused, making it quicker to determine if it&#39;s paused or \
                running
 - Double-click resets timer</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As it&#39;s a simple modification, I think that it brings no bugs \
(except by the fact that it says timeout when reseted with double-click).</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/timer/timer.h <span style="color: grey">(d191fa3)</span></li>

 <li>applets/timer/timer.cpp <span style="color: grey">(a09aa4c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100521/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 