[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Enabling "Apply" button in system-monitor
From: "Marco Martin" <notmart () gmail ! com>
Date: 2011-02-15 14:54:08
Message-ID: 20110215145408.5925.8101 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100660/#review1442
-----------------------------------------------------------
Ship it!
- Marco
On Feb. 15, 2011, 2:41 p.m., Sinny Kumari wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100660/
> -----------------------------------------------------------
> =
> (Updated Feb. 15, 2011, 2:41 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Enabling "Apply" buttons in system-monitor configuration dialog. It inclu=
des cpu, hdd, net, ram and temperature plasmoids.
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/system-monitor/cpu.cpp f47402d =
> plasma/generic/applets/system-monitor/hdd.cpp 5b6985e =
> plasma/generic/applets/system-monitor/net.cpp 7e38240 =
> plasma/generic/applets/system-monitor/ram.cpp ed7b031 =
> plasma/generic/applets/system-monitor/temperature.cpp 86dd170 =
> =
> Diff: http://git.reviewboard.kde.org/r/100660/diff
> =
> =
> Testing
> -------
> =
> works fine with all plasmoids.
> =
> =
> Thanks,
> =
> Sinny
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100660/">http://git.reviewboard.kde.org/r/100660/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Marco</p>
<br />
<p>On February 15th, 2011, 2:41 p.m., Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2011, 2:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enabling "Apply" buttons in system-monitor configuration \
dialog. It includes cpu, hdd, net, ram and temperature plasmoids.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine with all plasmoids.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/system-monitor/cpu.cpp <span style="color: \
grey">(f47402d)</span></li>
<li>plasma/generic/applets/system-monitor/hdd.cpp <span style="color: \
grey">(5b6985e)</span></li>
<li>plasma/generic/applets/system-monitor/net.cpp <span style="color: \
grey">(7e38240)</span></li>
<li>plasma/generic/applets/system-monitor/ram.cpp <span style="color: \
grey">(ed7b031)</span></li>
<li>plasma/generic/applets/system-monitor/temperature.cpp <span style="color: \
grey">(86dd170)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100660/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic