'Re: Review Request: Enable Apply button for plasma clock'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Enable Apply button for plasma clock
From:       "John Layt" <john () layt ! net>
Date:       2011-02-13 10:38:10
Message-ID: 20110213103810.12604.30207 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100620/#review1404
-----------------------------------------------------------

Ship it!

Looks good.

- John

On Feb. 12, 2011, 4:42 a.m., Rom=C3=A1rio Rios wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100620/
> -----------------------------------------------------------
> =

> (Updated Feb. 12, 2011, 4:42 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> Enables apply button for plasma clock. Dependens on patch http://git.revi=
ewboard.kde.org/r/100619/. Needed for http://git.reviewboard.kde.org/r/1006=
14/.
> =

> =

> Diffs
> -----
> =

>   libs/plasmaclock/calendartable.cpp f15f1ff =

>   libs/plasmaclock/clockapplet.cpp b806792 =

> =

> Diff: http://git.reviewboard.kde.org/r/100620/diff
> =

> =

> Testing
> -------
> =

> Seems to be fine.
> =

> =

> Thanks,
> =

> Rom=C3=A1rio
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100620/">http://git.reviewboard.kde.org/r/100620/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.</pre>  <br \
/>

<p>- John</p>

<br />
<p>On February 12th, 2011, 4:42 a.m., Romário Rios wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>

<p style="color: grey;"><i>Updated Feb. 12, 2011, 4:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enables apply button for plasma clock. Dependens on patch \
http://git.reviewboard.kde.org/r/100619/. Needed for \
http://git.reviewboard.kde.org/r/100614/.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems to be fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/plasmaclock/calendartable.cpp <span style="color: \
grey">(f15f1ff)</span></li>

 <li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(b806792)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100620/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 