[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Overrides Plasma::wallpaer method addUrls() to
From: "Thomas Braxton" <kde.braxton () gmail ! com>
Date: 2011-01-25 19:33:52
Message-ID: 20110125193352.16148.7804 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 25, 2011, 4:17 p.m., Thomas Braxton wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp, line 141
> > <http://svn.reviewboard.kde.org/r/6391/diff/2/?file=44483#file44483line141>
> >
> > shouldn't this be:
> > foreach(const KUrl& url, urls) ?
>
> Sinny Kumari wrote:
> I'm kinda new to development, would be nice if you could tell how its better. \
> Thanks :)
it doesn't use the copy constructor, it only copies a pointer so it's faster
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/#review9720
-----------------------------------------------------------
On Jan. 24, 2011, 7:49 p.m., Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6391/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2011, 7:49 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will override the \
> method defined ( changes that have been made in \
> http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set \
> Image. After reviewing it I will implement both changes in Frame Applet :)
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1216449
> trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1216449
>
> Diff: http://svn.reviewboard.kde.org/r/6391/diff
>
>
> Testing
> -------
>
> Tested in trunk and it works perfectly.
>
>
> Thanks,
>
> Sinny
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6391/">http://svn.reviewboard.kde.org/r/6391/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 25th, 2011, 4:17 p.m., <b>Thomas \
Braxton</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6391/diff/2/?file=44483#file44483line141" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void Image::addUrls(const KUrl::List &urls)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">141</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span><span class="n">url</span><span \
class="p">,</span> <span class="n">urls</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't this be: \
foreach(const KUrl& url, urls) ?</pre> </blockquote>
<p>On January 25th, 2011, 5:45 p.m., <b>Sinny Kumari</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm kinda new to \
development, would be nice if you could tell how its better. Thanks :)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it \
doesn't use the copy constructor, it only copies a pointer so it's \
faster</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 24th, 2011, 7:49 p.m., Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2011, 7:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS \
will override the method defined ( changes that have been made in \
http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set \
Image. After reviewing it I will implement both changes in Frame Applet :)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in trunk and it works perfectly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h <span \
style="color: grey">(1216449)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <span \
style="color: grey">(1216449)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6391/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic