[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Mime-type in NepomukSearchRunner
From: "Sebastian Trueg" <trueg () kde ! org>
Date: 2011-01-17 14:45:11
Message-ID: 20110117144511.8911.70873 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6338/#review9643
-----------------------------------------------------------
Ship it!
- Sebastian
On Jan. 17, 2011, 5:05 a.m., Amir Pakdel wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6338/
> -----------------------------------------------------------
> =
> (Updated Jan. 17, 2011, 5:05 a.m.)
> =
> =
> Review request for Plasma, Sebastian Trueg and Vishesh Handa.
> =
> =
> Summary
> -------
> =
> I have changed NepomukSearchRunner a little bit, so I could search for co=
ntents of notes (added by BasketNotepad) using KRunner.
> =
> It uses NIE:mimeType of the resource to set the "type" and "iconName" of =
the search result. If the resourse does not have NIE:mimeType property, KMi=
meType::findByUrl(url) is used instead (in order to find the mime-type asso=
ciated with the url of the resource).
> =
> When running/opening the search result, preferredService of the mime-type=
is used in invokation of KRun::run; therefore, the mime-type of the resour=
ce (or its url) indicates the service that would be used to run the resourc=
e.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/query=
clientwrapper.cpp 1193800 =
> /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepom=
uksearchrunner.cpp 1193800 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6338/diff
> =
> =
> Testing
> -------
> =
> I have searched for contents of notes that were added by BasketNotepad (u=
sing KRunner) and opened them in BasketNotepads.
> =
> =
> Thanks,
> =
> Amir
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6338/">http://svn.reviewboard.kde.org/r/6338/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Sebastian</p>
<br />
<p>On January 17th, 2011, 5:05 a.m., Amir Pakdel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Sebastian Trueg and Vishesh Handa.</div>
<div>By Amir Pakdel.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2011, 5:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have changed NepomukSearchRunner a little bit, so I could search for \
contents of notes (added by BasketNotepad) using KRunner.
It uses NIE:mimeType of the resource to set the "type" and \
"iconName" of the search result. If the resourse does not have NIE:mimeType \
property, KMimeType::findByUrl(url) is used instead (in order to find the mime-type \
associated with the url of the resource).
When running/opening the search result, preferredService of the mime-type is used in \
invokation of KRun::run; therefore, the mime-type of the resource (or its url) \
indicates the service that would be used to run the resource.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have searched for contents of notes that were added by BasketNotepad \
(using KRunner) and opened them in BasketNotepads.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp \
<span style="color: grey">(1193800)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp \
<span style="color: grey">(1193800)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6338/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic