[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Tasks applet: Make order independent of whether
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2011-01-10 18:58:03
Message-ID: 20110110185803.21924.64464 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 10, 2011, 10 a.m., Kåre Särs wrote:
> > There is a problem with the new behavior for forced row count.
> > Previously the "older" windows/buttons stayed at approximately the same place \
> > when new windows where opened/closed, but now more than half of the windows jump \
> > back and forth whenever a window is opened or closed. I made a longer explanation \
> > of my problem with the new behavior in the bug report that this patch tries to \
> > solve.
> > Should I maybe re-open the report?
> >
> > Regards,
> > Kåre
each way has its strengths and its challenges. adding an option to swap between the \
two ways is not a good solution in this case, so we need to pick one. i'm also \
uninterested in having it flip-flop back and forth in implementation. the way it is \
currently in 4.6 seems to cover a number of user needs very well. can't please \
everyone, as they say.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5776/#review9601
-----------------------------------------------------------
On Nov. 6, 2010, 8:58 p.m., Ingomar Wesp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5776/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2010, 8:58 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This should fix <https://bugs.kde.org/show_bug.cgi?id=215231>, but frankly I don't \
> understand why it was done this way in the first place...
>
> This addresses bug 215231.
> https://bugs.kde.org/show_bug.cgi?id=215231
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
> 1190987
> Diff: http://svn.reviewboard.kde.org/r/5776/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> 3 forced rows, 1-5 windows, trunk vs. patched
> http://svn.reviewboard.kde.org/r/5776/s/550/
>
>
> Thanks,
>
> Ingomar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5776/">http://svn.reviewboard.kde.org/r/5776/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 10th, 2011, 10 a.m., <b>Kåre Särs</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a \
problem with the new behavior for forced row count. Previously the "older" \
windows/buttons stayed at approximately the same place when new windows where \
opened/closed, but now more than half of the windows jump back and forth whenever a \
window is opened or closed. I made a longer explanation of my problem with the new \
behavior in the bug report that this patch tries to solve.
Should I maybe re-open the report?
Regards,
Kåre</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">each way has its \
strengths and its challenges. adding an option to swap between the two ways is not a \
good solution in this case, so we need to pick one. i'm also uninterested in \
having it flip-flop back and forth in implementation. the way it is currently in 4.6 \
seems to cover a number of user needs very well. can't please everyone, as they \
say.</pre> <br />
<p>- Aaron</p>
<br />
<p>On November 6th, 2010, 8:58 p.m., Ingomar Wesp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ingomar Wesp.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2010, 8:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This should fix <https://bugs.kde.org/show_bug.cgi?id=215231>, but \
frankly I don't understand why it was done this way in the first place...</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=215231">215231</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
<span style="color: grey">(1190987)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5776/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5776/s/550/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/06/3-forced-rows_400x100.png" \
style="border: 1px black solid;" alt="3 forced rows, 1-5 windows, trunk vs. patched" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic