[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Prevent plasma tooltips to draw halos on empty
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-12-29 17:57:31
Message-ID: 20101229175731.10430.61210 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6233/#review9467
-----------------------------------------------------------
Ship it!
good catch and simple solution ;)
- Marco
On 2010-12-29 17:55:36, Diego Casella wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6233/
> -----------------------------------------------------------
> =
> (Updated 2010-12-29 17:55:36)
> =
> =
> Review request for Plasma, Aaron Seigo and Marco Martin.
> =
> =
> Summary
> -------
> =
> In a multi-line Plasma tooltip, don't draw a halo around empty lines.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/private/tooltip.cpp 1210128 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6233/diff
> =
> =
> Testing
> -------
> =
> Test done with r1210128, results are shown in the screenshots below.
> =
> =
> Screenshots
> -----------
> =
> Calendar Tooltip
> http://svn.reviewboard.kde.org/r/6233/s/596/
> Calendar Tooltip patched
> http://svn.reviewboard.kde.org/r/6233/s/597/
> Clock Tooltip
> http://svn.reviewboard.kde.org/r/6233/s/598/
> Clock Tooltip patched
> http://svn.reviewboard.kde.org/r/6233/s/599/
> =
> =
> Thanks,
> =
> Diego
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6233/">http://svn.reviewboard.kde.org/r/6233/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good catch and simple \
solution ;)</pre> <br />
<p>- Marco</p>
<br />
<p>On December 29th, 2010, 5:55 p.m., Diego Casella wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Marco Martin.</div>
<div>By Diego Casella.</div>
<p style="color: grey;"><i>Updated 2010-12-29 17:55:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In a multi-line Plasma tooltip, don't draw a halo around empty \
lines.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test done with r1210128, results are shown in the screenshots \
below.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/private/tooltip.cpp <span style="color: \
grey">(1210128)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6233/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6233/s/596/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/29/calendar_tooltip_1_400x100.png" \
style="border: 1px black solid;" alt="Calendar Tooltip" /></a>
<a href="http://svn.reviewboard.kde.org/r/6233/s/597/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/29/calendar_tooltip_patched_1_400x100.png" \
style="border: 1px black solid;" alt="Calendar Tooltip patched" /></a>
<a href="http://svn.reviewboard.kde.org/r/6233/s/598/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/29/clock_tooltip_1_400x100.png" \
style="border: 1px black solid;" alt="Clock Tooltip" /></a>
<a href="http://svn.reviewboard.kde.org/r/6233/s/599/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/29/clock_tooltip_patched_1_400x100.png" \
style="border: 1px black solid;" alt="Clock Tooltip patched" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic