From kde-panel-devel Wed Dec 22 19:12:23 2010 From: "Aaron Seigo" Date: Wed, 22 Dec 2010 19:12:23 +0000 To: kde-panel-devel Subject: Re: Review Request: plasma Message-Id: <20101222191223.14460.89289 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129304519421016 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2114539214==" --===============2114539214== Content-Type: multipart/alternative; boundary="===============1259622864176770938==" --===============1259622864176770938== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6185/#review9372 ----------------------------------------------------------- Ship it! good catches, thanks :) - Aaron On 2010-12-22 14:08:04, Nicolas L=C3=A9cureuil wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6185/ > ----------------------------------------------------------- > = > (Updated 2010-12-22 14:08:04) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > in PackageStructurePrivate::createPackageMetadata there is a kWarning whi= ch is useless because the stream to show is cleared just before the kWarnin= g. > This small patch fixes this issue. > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/plasma/packagestructure.cpp 1208544 = > = > Diff: http://svn.reviewboard.kde.org/r/6185/diff > = > = > Testing > ------- > = > = > Thanks, > = > Nicolas > = > --===============1259622864176770938== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6185/

Ship it!

good catch=
es, thanks :)

- Aaron

On December 22nd, 2010, 2:08 p.m., Nicolas L=C3=A9cureuil wrote:

Review request for Plasma.

By Nicolas L=C3=A9cureuil.

Updated 2010-12-22 14:08:04

Descripti= on

in PackageStructurePrivate::createPackageMetadata there is a=
 kWarning which is useless because the stream to show is cleared just befor=
e the kWarning.
This small patch fixes this issue.

Diffs=

trunk/KDE/kdelibs/plasma/packagestructure.cpp (1208544)

View Diff

--===============1259622864176770938==-- --===============2114539214== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2114539214==--