From kde-panel-devel Wed Dec 22 19:10:55 2010 From: "Aaron Seigo" Date: Wed, 22 Dec 2010 19:10:55 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix crash in plasmapkg Message-Id: <20101222191055.14393.24029 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129304510220897 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1102586519==" --===============1102586519== Content-Type: multipart/alternative; boundary="===============0823796038891062585==" --===============0823796038891062585== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6184/#review9371 ----------------------------------------------------------- Ship it! - Aaron On 2010-12-22 13:35:33, Nicolas L=C3=A9cureuil wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6184/ > ----------------------------------------------------------- > = > (Updated 2010-12-22 13:35:33) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > when using plasmapkg -t theme -u /home/neoclust/.kde4/share/apps/desktopt= heme/G-Remix/metadata.desktop ( which is a wrong use of the tool i agree )= plasmapkg crash. > = > this is because archive is set to 0 and not checked before if (archive->o= pen(QIODevice::ReadOnly)) { > = > this patch fixes this crash > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/plasma/packagestructure.cpp 1208544 = > = > Diff: http://svn.reviewboard.kde.org/r/6184/diff > = > = > Testing > ------- > = > plasmapkg -t theme -u ${the file you want} > = > = > Thanks, > = > Nicolas > = > --===============0823796038891062585== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6184/

Ship it!

- Aaron

On December 22nd, 2010, 1:35 p.m., Nicolas L=C3=A9cureuil wrote:

Review request for Plasma.

By Nicolas L=C3=A9cureuil.

Updated 2010-12-22 13:35:33

Descripti= on

when using plasmapkg -t theme -u /home/neoclust/.kde4/share/=
apps/desktoptheme/G-Remix/metadata.desktop  ( which is a wrong use of the t=
ool i agree )  plasmapkg crash.

this is because archive is set to 0 and not checked before if (archive->=
open(QIODevice::ReadOnly)) {

this patch fixes this crash

Testing <= /h1>

plasmapkg -t theme -u ${the file you want}

Diffs=

trunk/KDE/kdelibs/plasma/packagestructure.cpp (1208544)

View Diff

--===============0823796038891062585==-- --===============1102586519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1102586519==--