[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Lockout widget: Explain to the user that he must
From: Nicolas_Lécureuil <neoclust.kde () free ! fr>
Date: 2010-12-22 14:13:15
Message-ID: 20101222141315.7414.3086 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6041/#review9365
-----------------------------------------------------------
as kde 4.6 have been branched, is it OK to commit this ?
- Nicolas
On 2010-12-05 21:41:56, Nicolas Lécureuil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6041/
> -----------------------------------------------------------
>
> (Updated 2010-12-05 21:41:56)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> When the user ask to show no buttons in the lockout widget, nothing tell the user \
> that this is not possible, and when he saves the configuration nothing changed in \
> the widget.
> With this patch, if the user unselect all the checkboxes, he is warned.
>
>
> This addresses bug 256879.
> https://bugs.kde.org/show_bug.cgi?id=256879
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h 1203948
> trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1203948
>
> Diff: http://svn.reviewboard.kde.org/r/6041/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nicolas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6041/">http://svn.reviewboard.kde.org/r/6041/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as kde 4.6 have been \
branched, is it OK to commit this ?</pre> <br />
<p>- Nicolas</p>
<br />
<p>On December 5th, 2010, 9:41 p.m., Nicolas Lécureuil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Nicolas Lécureuil.</div>
<p style="color: grey;"><i>Updated 2010-12-05 21:41:56</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the user ask to show no buttons in the lockout widget, nothing tell \
the user that this is not possible, and when he saves the configuration nothing \
changed in the widget.
With this patch, if the user unselect all the checkboxes, he is warned.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=256879">256879</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.h <span \
style="color: grey">(1203948)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp <span \
style="color: grey">(1203948)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6041/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic