'Review Request: Fix crash in plasmapkg'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix crash in plasmapkg
From:       Nicolas_Lécureuil <neoclust.kde () free ! fr>
Date:       2010-12-22 13:33:57
Message-ID: 20101222133357.6492.41860 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6184/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

when using plasmapkg -t theme -u /home/neoclust/.kde4/share/apps/desktopthe=
me/G-Remix/metadata.desktop  ( which is a wrong use of the tool i agree )  =
plasmapkg crash.

this is because archive is set to 0 and not checked before if (archive->ope=
n(QIODevice::ReadOnly)) {

this patch fixes this crash

Diffs
-----

  trunk/KDE/kdelibs/plasma/packagestructure.cpp 1208544 =

Diff: http://svn.reviewboard.kde.org/r/6184/diff

Testing
-------

plasmapkg -t theme -u ${the file you want}

Thanks,

Nicolas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6184/">http://svn.reviewboard.kde.org/r/6184/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Nicolas Lécureuil.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">when using plasmapkg -t theme -u \
/home/neoclust/.kde4/share/apps/desktoptheme/G-Remix/metadata.desktop  ( which is a \
wrong use of the tool i agree )  plasmapkg crash.

this is because archive is set to 0 and not checked before if \
(archive-&gt;open(QIODevice::ReadOnly)) {

this patch fixes this crash</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasmapkg -t theme -u ${the file you want}</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/packagestructure.cpp <span style="color: \
grey">(1208544)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6184/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 