[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Use correct pixmap cache file for theme
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-12-13 19:59:35
Message-ID: 20101213195935.27307.30631 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6100/#review9239
-----------------------------------------------------------
Ship it!
ah, that is sooo much clearer with the enumeration. thanks :)
- Aaron
On 2010-12-13 19:55:48, Manuel Mommertz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6100/
> -----------------------------------------------------------
> =
> (Updated 2010-12-13 19:55:48)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Currently when switching themes, the ondisk cache for pixmaps don't switc=
h to the correct file. This leads to not updated SVGs on theme change.
> =
> (For some reason folderview doesn't update. But currently no graphic upda=
tes.)
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/theme.cpp 1206183 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6100/diff
> =
> =
> Testing
> -------
> =
> Switching themes, system colors and compositing.
> =
> =
> Thanks,
> =
> Manuel
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6100/">http://svn.reviewboard.kde.org/r/6100/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, that is sooo much \
clearer with the enumeration. thanks :)</pre> <br />
<p>- Aaron</p>
<br />
<p>On December 13th, 2010, 7:55 p.m., Manuel Mommertz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Manuel Mommertz.</div>
<p style="color: grey;"><i>Updated 2010-12-13 19:55:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently when switching themes, the ondisk cache for pixmaps don't \
switch to the correct file. This leads to not updated SVGs on theme change.
(For some reason folderview doesn't update. But currently no graphic \
updates.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switching themes, system colors and compositing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/theme.cpp <span style="color: \
grey">(1206183)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6100/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic