'Re: Review Request: The clock applet chiming per hour,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: The clock applet chiming per hour,
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-12-13 19:17:36
Message-ID: 20101213191736.26519.18307 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6108/
-----------------------------------------------------------

(Updated 2010-12-13 19:17:35.920939)

Review request for Plasma and Anne-Marie Mahfouf.

Summary
-------

Hello Everybody,

i have implemented the chiming of the analog clock every hour.though i have hard \
coded it and it would only chime every hour. and not for 45 mins. Presently I am \
working on the development of a ui which would allow the user to set the clock to \
chime according to the choice of the user. 

thanks,
sunny_slls

This addresses bug 232004.
    https://bugs.kde.org/show_bug.cgi?id=232004

Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt \
1203585   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h \
1203585   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp \
1203585 

Diff: http://svn.reviewboard.kde.org/r/6108/diff

Testing
-------

Thanks,

Sunny

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6108/">http://svn.reviewboard.kde.org/r/6108/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Anne-Marie Mahfouf.</div>
<div>By Sunny Sharma.</div>

<p style="color: grey;"><i>Updated 2010-12-13 19:17:35.920939</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello Everybody,

i have implemented the chiming of the analog clock every hour.though i have hard \
coded it and it would only chime every hour. and not for 45 mins. Presently I am \
working on the development of a ui which would allow the user to set the clock to \
chime according to the choice of the user. 

thanks,
sunny_slls</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=232004">232004</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt \
<span style="color: grey">(1203585)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h <span \
style="color: grey">(1203585)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp <span \
style="color: grey">(1203585)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6108/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 