'Review Request: Contact runner works correctly in more cases'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Contact runner works correctly in more cases
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2010-12-11 12:54:08
Message-ID: 20101211125408.28393.46917 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6089/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Teemu Rytilahti.

Summary
-------

Works around BUG:249157 by using the form "NAME <EMAIL>" instead of "NAME<EMAIL>".
The first version is perfectly valid, the second that does not always work [1] might also be valid.

[1] Fails e.g. for NAME="a ü-a" or "ü-a"

CCBUG:249157

Diffs
-----

  /trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp 1205477 

Diff: http://svn.reviewboard.kde.org/r/6089/diff

Testing
-------

Thanks,

Matthias

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6089/">http://svn.reviewboard.kde.org/r/6089/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron Seigo and Teemu Rytilahti.</div>
<div>By Matthias Fuchs.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works around BUG:249157 by using the form &quot;NAME &lt;EMAIL&gt;&quot; \
instead of &quot;NAME&lt;EMAIL&gt;&quot;. The first version is perfectly valid, the \
second that does not always work [1] might also be valid.

[1] Fails e.g. for NAME=&quot;a ü-a&quot; or &quot;ü-a&quot;

CCBUG:249157</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp <span \
style="color: grey">(1205477)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6089/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 