'Re: Review Request: Plasma crash if lockout conf file is malformed.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma crash if lockout conf file is malformed.
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-12-05 22:40:41
Message-ID: 20101205224041.7310.8692 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6060/#review9146
-----------------------------------------------------------

Ship it!

makes sense to me (it's not doing anymore what te config says, but the cofig is \
saying actually to make a broken applet)

- Marco

On 2010-12-05 22:36:32, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6060/
> -----------------------------------------------------------
> 
> (Updated 2010-12-05 22:36:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> if on the plasma conf file we have for the lockout plasmoid :
> 
> showHibernateButton=false
> showLockButton=false
> showLogoutButton=false
> showSleepButton=false
> showSwitchUserButton=false
> 
> Plasma will crash.
> 
> This patch check this and provide a default setting if this happens.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1203948 
> 
> Diff: http://svn.reviewboard.kde.org/r/6060/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6060/">http://svn.reviewboard.kde.org/r/6060/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">makes sense to me \
(it&#39;s not doing anymore what te config says, but the cofig is saying actually to \
make a broken applet)</pre>  <br />

<p>- Marco</p>

<br />
<p>On December 5th, 2010, 10:36 p.m., Nicolas Lécureuil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Nicolas Lécureuil.</div>

<p style="color: grey;"><i>Updated 2010-12-05 22:36:32</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if on the plasma conf file we have for the lockout plasmoid :

showHibernateButton=false
showLockButton=false
showLogoutButton=false
showSleepButton=false
showSwitchUserButton=false

Plasma will crash.

This patch check this and provide a default setting if this happens.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp <span \
style="color: grey">(1203948)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6060/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 