[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Notes widget: Working
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2010-11-30 10:06:15
Message-ID: 20101130100615.28219.21999 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-30 01:04:03, Davide Bettio wrote:
> > Should we apply this patch while waiting someone who fix this bug in Qt?
> =
> Aaron Seigo wrote:
> sure (if only because the bug has been closed as "out of scope"), but=
annotate the code with a comment explaining the situation and a link to th=
e bug report on the qt bug tracker.
Just for clarity, I think it's similar to the bug I filed with Qt before, b=
ut maybe not the same. =
I think you should file a new Qt bug and link to that.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9050
-----------------------------------------------------------
On 2010-11-28 20:23:45, Davide Bettio wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
> =
> (Updated 2010-11-28 20:23:45)
> =
> =
> Review request for Plasma and Stephen Kelly.
> =
> =
> Summary
> -------
> =
> Text format of the note can't be changed while the note is empty, so I ad=
d a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review reque=
st also steveire.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Davide
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6005/">http://svn.reviewboard.kde.org/r/6005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 30th, 2010, 1:04 a.m., <b>Davide \
Bettio</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Should we apply this patch while waiting someone who fix this bug in \
Qt?</pre> </blockquote>
<p>On November 30th, 2010, 1:31 a.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sure (if only because \
the bug has been closed as "out of scope"), but annotate the code with a \
comment explaining the situation and a link to the bug report on the qt bug \
tracker.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just for clarity, I \
think it's similar to the bug I filed with Qt before, but maybe not the same.
I think you should file a new Qt bug and link to that.</pre>
<br />
<p>- Stephen</p>
<br />
<p>On November 28th, 2010, 8:23 p.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Stephen Kelly.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated 2010-11-28 20:23:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Text format of the note can't be changed while the note is empty, so \
I add a space and I change the text format. This work around is rather stupid but I \
don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add \
to this review request also steveire. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.h <span style="color: \
grey">(1201054)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <span style="color: \
grey">(1201054)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic