From kde-panel-devel Mon Nov 29 22:22:15 2010 From: "Matthias Fuchs" Date: Mon, 29 Nov 2010 22:22:15 +0000 To: kde-panel-devel Subject: Re: Review Request: Turns the slide effect off if KRunner is set to Message-Id: <20101129222215.14296.34200 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129106937519420 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1720397222==" --===============1720397222== Content-Type: multipart/alternative; boundary="===============7382791896539669520==" --===============7382791896539669520== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6006/ ----------------------------------------------------------- (Updated 2010-11-29 22:22:14.795984) Review request for kwin and Plasma. Changes ------- Implements what Martin suggested, or at least I think so. :) Seems to work nicely. Summary ------- Turns the slide effect off if floating is used. This is related to BUG:2186= 78 but does not completely fix it. Steps to reproduce: 1. set krunner to top screen, hide/show it 2. set krunner to floating 3. hide it 4. show it Step 3 and 4 use the slide-animation that should only be used if it is at t= he top. This patch fixes this behavior to some degree. Now only step three will use the slide animation and from that point on the= correct one will be used. I am not sure how I can also fix step 3, help welcome! :) Diffs (updated) ----- /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp 1202160 = /trunk/KDE/kdebase/workspace/kwin/effects/slidingpopups/slidingpopups.cpp= 1202160 = Diff: http://svn.reviewboard.kde.org/r/6006/diff Testing ------- Thanks, Matthias --===============7382791896539669520== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6006/

Review request for kwin and Plasma.
By Matthias Fuchs.

Updated 2010-11-29 22:22:14.795984

Changes 
Implements what Martin suggested, or at least I think so. :)
Seems to work nicely.

Descripti= on 

Turns the slide effect off if floating is used. This is rela=
ted to BUG:218678 but does not completely fix it.

Steps to reproduce:
1. set krunner to top screen, hide/show it
2. set krunner to floating
3. hide it
4. show it

Step 3 and 4 use the slide-animation that should only be used if it is at t=
he top.
This patch fixes this behavior to some degree.

Now only step three will use the slide animation and from that point on the=
 correct one will be used.
I am not sure how I can also fix step 3, help welcome! :)

Diffs= (updated)

  • /trunk/KDE/kdebase/workspace/krunner/krunnerdialog.cpp (1202160)
  • /trunk/KDE/kdebase/workspace/kwin/effects/slidingpopups/slidingpopups.= cpp (1202160)

View Diff
--===============7382791896539669520==-- --===============1720397222== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1720397222==--