[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Separate caching for unthemed SVGs requesting
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-11-28 23:52:17
Message-ID: 20101128235217.15166.86101 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6008/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
see: http://www.mail-archive.com/plasma-devel@kde.org/msg13494.html
this introduces a Theme object used by Svg to cache the rendering of svg's =
asking to be colorized, but which are not part of the theme. this requires =
an independent cache and set of color files, therefore a second Theme objec=
t. SvgPrivate::actualTheme() is thus overridden by SvgPrivate::cacheAndColo=
rsTheme() whenever caching or colors are used.
there are two remaining defects of varying severity, though neither is very=
high imho:
a) if the system color palette changes when the application is not running =
(or an svg using such a theme is not running) the cache will not be dropped=
. this is an existing issue, however, not something introduce by this patch=
set
b) the new system color theme is shared for performance reasons, but once c=
reated it is never deleted. it ought to be reference counted so it can be c=
leaned up after in use, but this is currently not done.
several other fixes crept into this patchset (sorry :/) including:
* not dropping the cache just because we change themes; this made sense whe=
n just plasma-desktop used this or when the apps using Plasma::Theme all us=
ed the same theme. this is no longer the case, really, and having applicati=
ons changing themes randomly kicking the cache out from underneath other ap=
ps that may still be using it is undesirable. this does mean that cache fil=
es will accumulate. not sure that's a big issue as they don't tend to be la=
rge and are in an area marked as "cache" (so ripe for clean-without-care)
* consolidate the signal/slot connections in SvgPrivate::checkColorHints, a=
nd now the check is consistent on all paths (previously, it wasn't!)
* missing (and possible cause of cache key ambiguity) separator in CACHE_ID=
_WITH_SIZE
* cleanups such as getting rid of superfluous use of Plasma:: namespacing i=
n code that is now in libplasma, such as the stylesheeting. (it was from a =
plasmoid sebas wrote originally, iirc, explaining the historical reason for=
the explicit namespacing)
in any case, consider this a draft at this stage. i'm interested in geting =
feedback, improvements and testing.
Diffs
-----
/trunk/KDE/kdelibs/plasma/private/svg_p.h 1199366 =
/trunk/KDE/kdelibs/plasma/svg.cpp 1201684 =
/trunk/KDE/kdelibs/plasma/theme.cpp 1201685 =
Diff: http://svn.reviewboard.kde.org/r/6008/diff
Testing
-------
just running normal plasma-desktop and what i use. needs testing with svg's=
that will actually rely on this feature.
Thanks,
Aaron
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6008/">http://svn.reviewboard.kde.org/r/6008/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron Seigo.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see: http://www.mail-archive.com/plasma-devel@kde.org/msg13494.html
this introduces a Theme object used by Svg to cache the rendering of svg's asking \
to be colorized, but which are not part of the theme. this requires an independent \
cache and set of color files, therefore a second Theme object. \
SvgPrivate::actualTheme() is thus overridden by SvgPrivate::cacheAndColorsTheme() \
whenever caching or colors are used.
there are two remaining defects of varying severity, though neither is very high \
imho:
a) if the system color palette changes when the application is not running (or an svg \
using such a theme is not running) the cache will not be dropped. this is an existing \
issue, however, not something introduce by this patchset
b) the new system color theme is shared for performance reasons, but once created it \
is never deleted. it ought to be reference counted so it can be cleaned up after in \
use, but this is currently not done.
several other fixes crept into this patchset (sorry :/) including:
* not dropping the cache just because we change themes; this made sense when just \
plasma-desktop used this or when the apps using Plasma::Theme all used the same \
theme. this is no longer the case, really, and having applications changing themes \
randomly kicking the cache out from underneath other apps that may still be using it \
is undesirable. this does mean that cache files will accumulate. not sure that's \
a big issue as they don't tend to be large and are in an area marked as \
"cache" (so ripe for clean-without-care)
* consolidate the signal/slot connections in SvgPrivate::checkColorHints, and now the \
check is consistent on all paths (previously, it wasn't!)
* missing (and possible cause of cache key ambiguity) separator in CACHE_ID_WITH_SIZE
* cleanups such as getting rid of superfluous use of Plasma:: namespacing in code \
that is now in libplasma, such as the stylesheeting. (it was from a plasmoid sebas \
wrote originally, iirc, explaining the historical reason for the explicit \
namespacing)
in any case, consider this a draft at this stage. i'm interested in geting \
feedback, improvements and testing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">just running normal plasma-desktop and what i use. needs testing with \
svg's that will actually rely on this feature.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/private/svg_p.h <span style="color: \
grey">(1199366)</span></li>
<li>/trunk/KDE/kdelibs/plasma/svg.cpp <span style="color: \
grey">(1201684)</span></li>
<li>/trunk/KDE/kdelibs/plasma/theme.cpp <span style="color: \
grey">(1201685)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6008/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic