From kde-panel-devel Sun Nov 28 11:35:52 2010 From: "Aaron Seigo" Date: Sun, 28 Nov 2010 11:35:52 +0000 To: kde-panel-devel Subject: Re: Review Request: Fixes QuickSand scrolling animation Message-Id: <20101128113552.30889.63532 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129094419303167 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0359545030==" --===============0359545030== Content-Type: multipart/alternative; boundary="===============8317082057754375029==" --===============8317082057754375029== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5988/#review9015 ----------------------------------------------------------- Ship it! looks like it also cleans up some dubious memory management with the time l= ine creation. - Aaron On 2010-11-27 21:04:37, Matthias Fuchs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5988/ > ----------------------------------------------------------- > = > (Updated 2010-11-27 21:04:37) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > If an animation is already running finish it before starting a new one. > BUG:209485 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.= h 1201458 = > /trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview.= cpp 1201458 = > = > Diff: http://svn.reviewboard.kde.org/r/5988/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matthias > = > --===============8317082057754375029== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5988/

Ship it!

looks like=
 it also cleans up some dubious memory management with the time line creati=
on.

- Aaron

On November 27th, 2010, 9:04 p.m., Matthias Fuchs wrote:

Review request for Plasma.

By Matthias Fuchs.

Updated 2010-11-27 21:04:37

Descripti= on

If an animation is already running finish it before starting=
 a new one.
BUG:209485

Diffs=

/trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview= .h (1201458)
/trunk/KDE/kdebase/workspace/krunner/interfaces/quicksand/qs_matchview= .cpp (1201458)

View Diff

--===============8317082057754375029==-- --===============0359545030== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0359545030==--