[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Kickoff application uninstaller
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-11-26 0:12:31
Message-ID: 20101126001231.30336.43412 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5974/#review8981
-----------------------------------------------------------
Ship it!
a comment in the code explaining why an activatable is being checked for wo=
uld be nice.
- Aaron
On 2010-11-25 23:48:05, Daniel Nicoletti wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5974/
> -----------------------------------------------------------
> =
> (Updated 2010-11-25 23:48:05)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Patch to use PackageKit session interface to "Uninstall" the applications.
> When kickoff starts it checks if the session interface is available, if i=
t's not available the
> right click option to "Uninstall" applications will not be displayed.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextm=
enufactory.cpp 1200785 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5974/diff
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Kickoff Uninstaller
> http://svn.reviewboard.kde.org/r/5974/s/563/
> =
> =
> Thanks,
> =
> Daniel
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5974/">http://svn.reviewboard.kde.org/r/5974/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a comment in the code \
explaining why an activatable is being checked for would be nice.</pre> <br />
<p>- Aaron</p>
<br />
<p>On November 25th, 2010, 11:48 p.m., Daniel Nicoletti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Daniel Nicoletti.</div>
<p style="color: grey;"><i>Updated 2010-11-25 23:48:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch to use PackageKit session interface to "Uninstall" the \
applications. When kickoff starts it checks if the session interface is available, if \
it's not available the right click option to "Uninstall" applications \
will not be displayed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp \
<span style="color: grey">(1200785)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5974/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5974/s/563/"><img \
src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="Kickoff \
Uninstaller" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic