[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Launchersupport in the Tasks-applet
From: "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date: 2010-11-09 20:52:13
Message-ID: 20101109205213.10575.76973 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-07 17:46:39, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp, lines \
> > 224-229 <http://svn.reviewboard.kde.org/r/5786/diff/1/?file=40735#file40735line224>
> >
> > instead of a stringlist, would it make more sense to have a config group for each \
> > launcher? e.g. something like:
> > KConfigGroup launcherCg(&cg, "Launchers");
> > launcherCg = KConfigGroup(&launcherCg, launcher->name());
> >
> > launcherCg.writeEntry("Url", launcher->url());
> > lunchgerCg.writeEntry("Icon", ....
The config-file looks cleaner like with the stringlist, and as I don't see any \
disadvantages in this method I think it's the better one.
- Anton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5786/#review8540
-----------------------------------------------------------
On 2010-11-07 14:08:45, Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5786/
> -----------------------------------------------------------
>
> (Updated 2010-11-07 14:08:45)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Implementation of the launchersupport in plasma's "Tasks"-applet. It depends on \
> http://svn.reviewboard.kde.org/r/5785/
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/CMakeLists.txt 1187984
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h \
> 1187984
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
> 1187984
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.h \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1187984 \
>
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
> 1187984
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1187984
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1187984
>
> Diff: http://svn.reviewboard.kde.org/r/5786/diff
>
>
> Testing
> -------
>
> tested, everything worked well so far.
>
>
> Thanks,
>
> Anton
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5786/">http://svn.reviewboard.kde.org/r/5786/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 7th, 2010, 5:46 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5786/diff/1/?file=40735#file40735line224" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void Tasks::launcherAdded(LauncherItem *launcher)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">224</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QStringList</span> <span class="n">launcherProperties</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">225</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">launcherProperties</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">launcher</span><span \
class="o">-></span><span class="n">url</span><span class="p">().</span><span \
class="n">url</span><span class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">226</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">launcherProperties</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">launcher</span><span \
class="o">-></span><span class="n">icon</span><span class="p">().</span><span \
class="n">name</span><span class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">227</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">launcherProperties</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">launcher</span><span \
class="o">-></span><span class="n">name</span><span \
class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">228</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">launcherProperties</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">launcher</span><span \
class="o">-></span><span class="n">genericName</span><span \
class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">229</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">launcherCg</span><span class="p">.</span><span \
class="n">writeEntry</span><span class="p">(</span><span \
class="n">launcher</span><span class="o">-></span><span class="n">name</span><span \
class="p">(),</span> <span class="n">launcherProperties</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of a stringlist, \
would it make more sense to have a config group for each launcher? e.g. something \
like:
KConfigGroup launcherCg(&cg, "Launchers");
launcherCg = KConfigGroup(&launcherCg, launcher->name());
launcherCg.writeEntry("Url", launcher->url());
lunchgerCg.writeEntry("Icon", ....</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The \
config-file looks cleaner like with the stringlist, and as I don't see any \
disadvantages in this method I think it's the better one.</pre> <br />
<p>- Anton</p>
<br />
<p>On November 7th, 2010, 2:08 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated 2010-11-07 14:08:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implementation of the launchersupport in plasma's \
"Tasks"-applet. It depends on http://svn.reviewboard.kde.org/r/5785/</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested, everything worked well so far.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/CMakeLists.txt <span \
style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h \
<span style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp \
<span style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp \
<span style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp \
<span style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h <span \
style="color: grey">(1187984)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp <span \
style="color: grey">(1187984)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5786/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic