'Re: Review Request: Launchersupport in libtaskmanager - final'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Launchersupport in libtaskmanager - final
From:       "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date:       2010-11-07 13:19:14
Message-ID: 20101107131914.19972.16945 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5785/
-----------------------------------------------------------

(Updated 2010-11-07 13:19:14.069931)

Review request for Plasma.

Summary
-------

This is the final implementation of the launchersupport for libtaskmanager.=
 Many parts of the initial implementation has been changed but now everythi=
ng works as it should.

Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1193=
833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 11=
93833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1=
193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp =
1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrat=
egy.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstr=
ategy.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1193833 =

  trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1193833 =

Diff: http://svn.reviewboard.kde.org/r/5785/diff

Testing
-------

Tested and everything worked fine.

Thanks,

Anton

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5785/">http://svn.reviewboard.kde.org/r/5785/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>

<p style="color: grey;"><i>Updated 2010-11-07 13:19:14.069931</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the final implementation of the launchersupport for \
libtaskmanager. Many parts of the initial implementation has been changed but now \
everything works as it should.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and everything worked fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp <span \
style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp \
<span style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp \
<span style="color: grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h <span style="color: \
grey">(1193833)</span></li>

 <li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h <span style="color: \
grey">(1193833)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5785/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 