[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make custom colours work on the digital clock
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-11-04 18:13:53
Message-ID: 20101104181353.28708.14344 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/#review8508
-----------------------------------------------------------
Ship it!
one small change up, and then i guess it's good to go.
Screenshot: Updated
<http://svn.reviewboard.kde.org//r/5747/#scomment43>
should also be disabled when the widgets are
- Aaron
On 2010-11-04 17:57:08, Alex Merry wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5747/
> -----------------------------------------------------------
> =
> (Updated 2010-11-04 17:57:08)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Since the shadow was introduced for the digital clock a few weeks ago, th=
e custom colour setting has been ignored. This re-enables it, and also all=
ows the user to choose a shadow colour.
> =
> This changes the configuration dialog and introduces a new option, which =
is why I'm submitting it for review before committing.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock=
.h 1192604 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock=
.cpp 1192604 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock=
Config.ui 1192604 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5747/diff
> =
> =
> Testing
> -------
> =
> Changing, saving and loading the settings worked in plasmoid-viewer.
> =
> =
> Screenshots
> -----------
> =
> The changed configuration
> http://svn.reviewboard.kde.org/r/5747/s/546/
> Updated
> http://svn.reviewboard.kde.org/r/5747/s/549/
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5747/">http://svn.reviewboard.kde.org/r/5747/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">one small change up, and \
then i guess it's good to go.</pre> <br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td><a href="/r/5747/s/549/" style="color: black; font-weight: bold; font-size: \
9pt;">clock-config1.png</a></td> </tr>
<tr>
<td><a href="http://svn.reviewboard.kde.org/r/5747/s/549/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/04/clock-config1_159_212_141_20.png" \
style="border: 1px black solid;" alt="Updated"></a></td> </tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should also \
be disabled when the widgets are</pre> <br />
<p>- Aaron</p>
<br />
<p>On November 4th, 2010, 5:57 p.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated 2010-11-04 17:57:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since the shadow was introduced for the digital clock a few weeks ago, \
the custom colour setting has been ignored. This re-enables it, and also allows the \
user to choose a shadow colour.
This changes the configuration dialog and introduces a new option, which is why \
I'm submitting it for review before committing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changing, saving and loading the settings worked in \
plasmoid-viewer.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h <span \
style="color: grey">(1192604)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp \
<span style="color: grey">(1192604)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui \
<span style="color: grey">(1192604)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5747/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5747/s/546/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/04/clock-config_400x100.png" \
style="border: 1px black solid;" alt="The changed configuration" /></a>
<a href="http://svn.reviewboard.kde.org/r/5747/s/549/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/04/clock-config1_400x100.png" \
style="border: 1px black solid;" alt="Updated" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic