This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5705/

Ship it!

looks good=
, inc the tooltips, just fix up the braces situation before committing. tha=
nks :)

= =


void Image::systemCheckBoxToggled(bool checked)
	260	if (checked)
	261	m_dirs << KStandardDirs::installPath("wallpaper");
	262	else
	263	m_dirs.removeAll(KStandardDirs::installPath(&= quot;wallpaper"));

braces

= =


void Image::systemCheckBoxToggled(bool checked)
	269	if (checked)
	270	m_dirs << KGlobal::dirs()->saveLocation("wallpaper"= );
	271	else
	272	m_dirs.removeAll(KGlobal::dirs()->= saveLocation("wallpaper"));

braces

= =

/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/i= mage.cpp (Diff revision 2)
void Image::removeDir()
	389	if (m_uiSlideshow.m_systemCheckBox->isChecked())
	390	m_dirs << KStandardDirs::installPath("wallpaper");
	391	if (m_uiSlideshow.m_downloadedCheckBox->isChecked())
	392	m_dirs << KGlobal::dirs()->saveLocation("wallpaper"= );

braces

- Aaron

On October 30th, 2010, 10:50 p.m., Jeremy Whiting wrote:

Review request for Plasma and Davide Bettio.

By Jeremy Whiting.

Updated 2010-10-30 22:50:25

Descripti= on

Prompted by bug https://bugs.kde.org/show_bug.cgi?id=3D25336=
0 and my own itch at not having the ability to easly add ~/.kde/share/wallp=
aper/ to the slideshow, I added these two checkboxes from this wishlist bug=
.  Let me know if you think the tooltips should be reworded I just took an =
initial stab at them.

Testing <= /h1>

I works quite well actually.  I still think we need to disab=
le the apply and ok buttons when no checkbox is checked and no paths are in=
 the listbox, but we work around that by putting the system folder in the l=
ist if there are no folders in the kconfig.

Diffs=

/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h <= span style=3D"color: grey">(1190748)
/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp= (1190748)
/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshow= config.ui (1190748)

View Diff

Descripti= on

Testing <= /h1> I works quite well actually. I still think we need to disab= le the apply and ok buttons when no checkbox is checked and no paths are in= the listbox, but we work around that by putting the system folder in the l= ist if there are no folders in the kconfig.

Diffs=

Testing <= /h1>

I works quite well actually. I still think we need to disab= le the apply and ok buttons when no checkbox is checked and no paths are in= the listbox, but we work around that by putting the system folder in the l= ist if there are no folders in the kconfig.