--===============1780624279== Content-Type: multipart/alternative; boundary="===============3386044631315203010==" --===============3386044631315203010== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-10-28 13:25:15, Anne-Marie Mahfouf wrote: > > It's fine. Maybe there should be a setting showing the tooltip or not, = for example when a user has several picture frames the tooltip is shown on = another one which can be annoying. = > > Any feedback from other people about having it as a setting? > = > Sujith H wrote: > I agree with you. Thumbs up for the idea :) I don't think another config option for tooltips should be a good idea, alm= ost all applets have tooltips, its not bad to have them. Additional config options are an evil, imho we should keep the tooltip a de= fault. - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8409 ----------------------------------------------------------- On 2010-10-20 17:44:12, Sujith H wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5660/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 17:44:12) > = > = > Review request for Plasma and Anne-Marie Mahfouf. > = > = > Summary > ------- > = > Added the filename as tooltip for the frame applet. The filename will be = displayed as the > tooltip when the user moves the moves on the frame. > = > = > Diffs > ----- > = > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 = > = > Diff: http://svn.reviewboard.kde.org/r/5660/diff > = > = > Testing > ------- > = > Tested on the set of pictures I had in my laptop. > = > = > Thanks, > = > Sujith > = > --===============3386044631315203010== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5660/

On October 28th, 2010, 1:25 p.m., Anne-Mari= e Mahfouf wrote:

It's =
fine. Maybe there should be a setting showing the tooltip or not, for examp=
le when a user has several picture frames the tooltip is shown on another o=
ne which can be annoying. =

Any feedback from other people about having it as a setting?

On October 28th, 2010, 3:51 p.m., Sujith H wrote:

I agree w=
ith you. Thumbs up for the idea :)

I don't=
 think another config option for tooltips should be a good idea, almost all=
 applets have tooltips, its not bad to have them.
Additional config options are an evil, imho we should keep the tooltip a de=
fault.

- Shantanu

On October 20th, 2010, 5:44 p.m., Sujith H wrote:

Review request for Plasma and Anne-Marie Mahfouf.

By Sujith H.

Updated 2010-10-20 17:44:12

Descripti= on

Added the filename as tooltip for the frame applet. The file=
name will be displayed as the
tooltip when the user moves the moves on the frame.

Testing <= /h1>

Tested on the set of pictures I had in my laptop.

Diffs=

trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp (1187544)

--===============3386044631315203010==-- --===============1780624279== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1780624279==--