[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Microblog: small patch so that microblog
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-10-21 15:39:47
Message-ID: 20101021153947.14885.4823 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5679/#review8290
-----------------------------------------------------------
for me is okay, even if an obscured password directly in the config file isn't great...
some time ago it did already this thing, why was it removed?
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp
<http://svn.reviewboard.kde.org/r/5679/#comment8566>
here we use brackets also for one line ifs
if () {
} else {
}
- Marco
On 2010-10-21 15:18:12, Mohit Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5679/
> -----------------------------------------------------------
>
> (Updated 2010-10-21 15:18:12)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> It was a bug posted on bugs.kde.org,
> Here is the link: https://bugs.kde.org/show_bug.cgi?id=242377
> Well it did stored the password in config file but never read it.
> So i just added the reading feature and reloaded the history.
>
>
> Diffs
> -----
>
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp 1187571
>
> Diff: http://svn.reviewboard.kde.org/r/5679/diff
>
>
> Testing
> -------
>
> I tested it on kdeplasma-addons revision 1187571
>
>
> Thanks,
>
> Mohit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5679/">http://svn.reviewboard.kde.org/r/5679/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for me is okay, even if \
an obscured password directly in the config file isn't great... some time ago it \
did already this thing, why was it removed?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5679/diff/2/?file=39870#file39870line469" \
style="color: black; font-weight: bold; text-decoration: \
underline;">svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MicroBlog::getWallet()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">469</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="n">m_password</span><span \
class="p">.</span><span class="n">isEmpty</span><span class="p">())</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">here we use \
brackets also for one line ifs if () {
} else {
}</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On October 21st, 2010, 3:18 p.m., Mohit Kothari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mohit Kothari.</div>
<p style="color: grey;"><i>Updated 2010-10-21 15:18:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It was a bug posted on bugs.kde.org, Here is the link: \
https://bugs.kde.org/show_bug.cgi?id=242377 Well it did stored the password in config \
file but never read it. So i just added the reading feature and reloaded the \
history.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested it on kdeplasma-addons revision 1187571</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp \
<span style="color: grey">(1187571)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5679/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic