[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adding filename as tooltip for frame applet
From: "Sujith H" <sujith.h () gmail ! com>
Date: 2010-10-20 17:44:08
Message-ID: 20101020174408.31929.32037 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-20 17:24:50, Ingomar Wesp wrote:
> > I'm not the maintainer of the applet, so I'm sorry that I can only comm=
ent on the code itself, not on whether it should go into the applet.
> > =
> > I noticed a few issues:
> > - The includes are still in the header. Since you've removed the member=
variable, you can remove them as well.
> > - The user visible text "File:" you're setting as main text needs to go=
through i18n.
> > - You're setting the tooltip content twice (the first call to ToolTipMa=
nager::setContent is unnecessary IMHO).
> >
Ok, I can understand that. =
-I had removed the changes in the header file. Now when I do 'svn status' i=
n my working machine, I can find only frame.cpp file updated.
-I had changed the "File:" to i18n.
-My mistake removed the first call to ToolTipManager::setContent
- Sujith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5660/#review8275
-----------------------------------------------------------
On 2010-10-20 15:47:47, Sujith H wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5660/
> -----------------------------------------------------------
> =
> (Updated 2010-10-20 15:47:47)
> =
> =
> Review request for Plasma and Anne-Marie Mahfouf.
> =
> =
> Summary
> -------
> =
> Added the filename as tooltip for the frame applet. The filename will be =
displayed as the
> tooltip when the user moves the moves on the frame.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5660/diff
> =
> =
> Testing
> -------
> =
> Tested on the set of pictures I had in my laptop.
> =
> =
> Thanks,
> =
> Sujith
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5660/">http://svn.reviewboard.kde.org/r/5660/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 20th, 2010, 5:24 p.m., <b>Ingomar \
Wesp</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not the maintainer of the applet, so I'm sorry that I can \
only comment on the code itself, not on whether it should go into the applet.
I noticed a few issues:
- The includes are still in the header. Since you've removed the member variable, \
you can remove them as well.
- The user visible text "File:" you're setting as main text needs to go \
through i18n.
- You're setting the tooltip content twice (the first call to \
ToolTipManager::setContent is unnecessary IMHO). </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I can understand \
that.
-I had removed the changes in the header file. Now when I do 'svn status' in \
my working machine, I can find only frame.cpp file updated.
-I had changed the "File:" to i18n.
-My mistake removed the first call to ToolTipManager::setContent
</pre>
<br />
<p>- Sujith </p>
<br />
<p>On October 20th, 2010, 3:47 p.m., Sujith H wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Anne-Marie Mahfouf.</div>
<div>By Sujith H.</div>
<p style="color: grey;"><i>Updated 2010-10-20 15:47:47</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added the filename as tooltip for the frame applet. The filename will be \
displayed as the tooltip when the user moves the moves on the frame.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on the set of pictures I had in my laptop.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp <span style="color: \
grey">(1187544)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5660/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic