[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add call action to contact runner
From: "Bart Visscher" <bartv () thisnet ! nl>
Date: 2010-10-17 8:34:39
Message-ID: 20101017083439.3348.9795 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-12 20:13:41, Marco Martin wrote:
> > too bad there isn't a check in akonadi for the application existence, b=
ut if the action still "does" something it's ok
can someone commit this, i don't have commit access
- Bart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5604/#review8100
-----------------------------------------------------------
On 2010-10-12 21:13:20, Bart Visscher wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5604/
> -----------------------------------------------------------
> =
> (Updated 2010-10-12 21:13:20)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> When a contact has a phonenumber add an action to display/call this conta=
ct.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeplasma-addons/runners/contacts/CMakeLists.txt 1182509 =
> /trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp 1182509 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5604/diff
> =
> =
> Testing
> -------
> =
> search for a contact and activated the call action
> =
> =
> Thanks,
> =
> Bart
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5604/">http://svn.reviewboard.kde.org/r/5604/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 12th, 2010, 8:13 p.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">too bad there isn't a check in akonadi for the application \
existence, but if the action still "does" something it's ok</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can someone commit this, \
i don't have commit access</pre> <br />
<p>- Bart</p>
<br />
<p>On October 12th, 2010, 9:13 p.m., Bart Visscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bart Visscher.</div>
<p style="color: grey;"><i>Updated 2010-10-12 21:13:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When a contact has a phonenumber add an action to display/call this \
contact.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">search for a contact and activated the call action</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/runners/contacts/CMakeLists.txt <span style="color: \
grey">(1182509)</span></li>
<li>/trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp <span \
style="color: grey">(1182509)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5604/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic