[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Startup Feedback KWin Effect
From: "Lubos Lunak" <l.lunak () kde ! org>
Date: 2010-10-11 11:57:58
Message-ID: 20101011115758.7562.47986 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5529/#review8075
-----------------------------------------------------------
Ship it!
Seems ok.
- Lubos
On 2010-10-06 08:44:46, Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5529/
> -----------------------------------------------------------
> =
> (Updated 2010-10-06 08:44:46)
> =
> =
> Review request for kwin, Plasma and Lubos Lunak.
> =
> =
> Summary
> -------
> =
> Implemented an OpenGL based Startup Feedback effect to replace the functi=
onality provided by StartupId in KRunner when effects are available. The ef=
fect supports the three modes bouncing, blinking and passive in exactly the=
same way as the current existing functionality.
> =
> Using an effect has several advantages:
> * we do not need to remove the alpha channel from the icons
> * no need to move windows around, shape and raise them
> * no need to prepare several pixmaps for blinking mode as OpenGL provide=
s the same functionality using texture modulation (have I ever mentioned th=
at I hate texture modulation?)
> =
> The effect is completely controlled by KRunner through DBus, when a start=
up is added the effect get's activated, when the last current startup is re=
moved the effect gets deactivated again. The DBus call has to pass the type=
(bouncing, blinking or passive) and the icon name to the effect.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/workspace/kcontrol/launch/CMakeLists.txt 1174006 =
> trunk/KDE/kdebase/workspace/kcontrol/launch/interface_util.h PRE-CREATI=
ON =
> trunk/KDE/kdebase/workspace/kcontrol/launch/kcmlaunch.cpp 1174006 =
> trunk/KDE/kdebase/workspace/krunner/startupid.h 1182634 =
> trunk/KDE/kdebase/workspace/krunner/startupid.cpp 1182634 =
> trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1182656 =
> trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/CMakeLists.txt=
PRE-CREATION =
> trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedbac=
k.h PRE-CREATION =
> trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedbac=
k.cpp PRE-CREATION =
> trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedbac=
k.desktop PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/5529/diff
> =
> =
> Testing
> -------
> =
> * StartupId uses KWin effect when effect is present
> * Changing mode works
> * StartupId uses "legacy" window when effect is not present.
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5529/">http://svn.reviewboard.kde.org/r/5529/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems ok.</pre> <br />
<p>- Lubos</p>
<br />
<p>On October 6th, 2010, 8:44 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Lubos Lunak.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated 2010-10-06 08:44:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented an OpenGL based Startup Feedback effect to replace the \
functionality provided by StartupId in KRunner when effects are available. The effect \
supports the three modes bouncing, blinking and passive in exactly the same way as \
the current existing functionality.
Using an effect has several advantages:
* we do not need to remove the alpha channel from the icons
* no need to move windows around, shape and raise them
* no need to prepare several pixmaps for blinking mode as OpenGL provides the same \
functionality using texture modulation (have I ever mentioned that I hate texture \
modulation?)
The effect is completely controlled by KRunner through DBus, when a startup is added \
the effect get's activated, when the last current startup is removed the effect \
gets deactivated again. The DBus call has to pass the type (bouncing, blinking or \
passive) and the icon name to the effect.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* StartupId uses KWin effect when effect is present
* Changing mode works
* StartupId uses "legacy" window when effect is not present.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/kcontrol/launch/CMakeLists.txt <span style="color: \
grey">(1174006)</span></li>
<li>trunk/KDE/kdebase/workspace/kcontrol/launch/interface_util.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kcontrol/launch/kcmlaunch.cpp <span style="color: \
grey">(1174006)</span></li>
<li>trunk/KDE/kdebase/workspace/krunner/startupid.h <span style="color: \
grey">(1182634)</span></li>
<li>trunk/KDE/kdebase/workspace/krunner/startupid.cpp <span style="color: \
grey">(1182634)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1182656)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/startupfeedback/startupfeedback.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5529/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic