[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Use Plasma::ScrollWidget in the widget explorer
From: "Anselmo L. S. Melo" <anselmo.melo () openbossa ! org>
Date: 2010-10-06 17:02:16
Message-ID: 20101006170216.21695.14627 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-01 17:21:28, Aaron Seigo wrote:
> > update to current trunk if needed, and let's get this in as well.
>
> Anselmo L. S. Melo wrote:
> @agateau: I've updated this patch to current trunk [1] - I updated it when I wrote \
> another patch [2], to check if both patches were ok together. Now it is an updated \
> version on top of today's trunk =)
> [1] - http://anselmolsm.org/public/kde/plasma-addwidget-scrollwidget-r1181856.diff
> [2] - http://reviewboard.kde.org/r/5446/
>
> Aurélien Gâteau wrote:
> Sounds good, please commit your updated version if it's not already in (/me needs \
> to update his trunk checkout)
> Anselmo L. S. Melo wrote:
> Ok, I'll commit tomorrow morning here (UTC-3) =)
Don't consider the previous comment, it was saved but not published in reviewboard.
Commited in r1183238.
- Anselmo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4676/#review7930
-----------------------------------------------------------
On 2010-08-04 21:02:11, Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4676/
> -----------------------------------------------------------
>
> (Updated 2010-08-04 21:02:11)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on \
> plasma-devel.
> The horizontal orientation behaved a bit strangely: AbstractIconList was becoming \
> much larger than the screen width. I had to change the layout code to include the \
> "Close" button inside FilteringWidget layout instead of creating another layout.
> Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider \
> sizes.
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp 1147944
> trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h \
> 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp \
> 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h \
> 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp \
> 1147944 trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp \
> 1147944
> Diff: http://svn.reviewboard.kde.org/r/4676/diff
>
>
> Testing
> -------
>
> Tested in both horizontal and vertical modes, with lists larger and smaller than \
> the view.
>
> Thanks,
>
> Aurélien
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4676/">http://svn.reviewboard.kde.org/r/4676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2010, 5:21 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">update to current trunk if needed, and let's get this in as \
well.</pre> </blockquote>
<p>On October 2nd, 2010, 3:11 p.m., <b>Anselmo L. S. Melo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@agateau: I've \
updated this patch to current trunk [1] - I updated it when I wrote another patch \
[2], to check if both patches were ok together. Now it is an updated version on top \
of today's trunk =)
[1] - http://anselmolsm.org/public/kde/plasma-addwidget-scrollwidget-r1181856.diff
[2] - http://reviewboard.kde.org/r/5446/</pre>
</blockquote>
<p>On October 5th, 2010, 8:52 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds good, please \
commit your updated version if it's not already in (/me needs to update his trunk \
checkout)</pre> </blockquote>
<p>On October 6th, 2010, 4:52 p.m., <b>Anselmo L. S. Melo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I'll commit \
tomorrow morning here (UTC-3) =)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't consider the \
previous comment, it was saved but not published in reviewboard.
Commited in r1183238.</pre>
<br />
<p>- Anselmo</p>
<br />
<p>On August 4th, 2010, 9:02 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-08-04 21:02:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed \
on plasma-devel.
The horizontal orientation behaved a bit strangely: AbstractIconList was becoming \
much larger than the screen width. I had to change the layout code to include the \
"Close" button inside FilteringWidget layout instead of creating another \
layout.
Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider \
sizes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in both horizontal and vertical modes, with lists larger and \
smaller than the view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h <span \
style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp <span \
style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp \
<span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp \
<span style="color: grey">(1147944)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4676/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic