[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Do not show archived lists in RemberTheMilk applet
From: "Riccardo Iaconelli" <riccardo () kde ! org>
Date: 2010-10-04 11:24:57
Message-ID: 20101004112457.23701.38494 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3864/#review7961
-----------------------------------------------------------
has this ever been reviewed/submitted?
- Riccardo
On 2010-05-02 08:04:16, Alexander Egger wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3864/
> -----------------------------------------------------------
> =
> (Updated 2010-05-02 08:04:16)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> The RememberTheMilk applet should not show archived lists. This is the wa=
y RTM does it in it's web UI.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/listssource.cpp=
1119441 =
> /trunk/KDE/kdeplasma-addons/libs/rtm/list.h 1119441 =
> /trunk/KDE/kdeplasma-addons/libs/rtm/list.cpp 1119441 =
> /trunk/KDE/kdeplasma-addons/libs/rtm/xmlreaders.cpp 1119441 =
> =
> Diff: http://svn.reviewboard.kde.org/r/3864/diff
> =
> =
> Testing
> -------
> =
> The modified applet runs on my desktop and does not show the archived lis=
ts. Sorry no more testing done :-(
> =
> =
> Thanks,
> =
> Alexander
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/3864/">http://svn.reviewboard.kde.org/r/3864/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">has this ever been \
reviewed/submitted?</pre> <br />
<p>- Riccardo</p>
<br />
<p>On May 2nd, 2010, 8:04 a.m., Alexander Egger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alexander Egger.</div>
<p style="color: grey;"><i>Updated 2010-05-02 08:04:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The RememberTheMilk applet should not show archived lists. This is the \
way RTM does it in it's web UI.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The modified applet runs on my desktop and does not show the archived \
lists. Sorry no more testing done :-(</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/listssource.cpp <span \
style="color: grey">(1119441)</span></li>
<li>/trunk/KDE/kdeplasma-addons/libs/rtm/list.h <span style="color: \
grey">(1119441)</span></li>
<li>/trunk/KDE/kdeplasma-addons/libs/rtm/list.cpp <span style="color: \
grey">(1119441)</span></li>
<li>/trunk/KDE/kdeplasma-addons/libs/rtm/xmlreaders.cpp <span style="color: \
grey">(1119441)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/3864/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic