'Review Request: kdebase: add support for ScriptEngine::evaluate() in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: kdebase: add support for ScriptEngine::evaluate() in
From:       "Martin Blumenstingl" <darklight.xdarklight () googlemail ! com>
Date:       2010-10-03 18:10:49
Message-ID: 20101003181049.528.30062 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5526/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

This adds support for evaluating code statements in the JavaScript Engine.
Please note that this depends on http://svn.reviewboard.kde.org/r/5525/

If this one gets approved I'll start working on the other engines.
I hope porting this to other engines is possible.

Diffs
-----

  /trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/common/scripte=
nv.h 1182146 =

  /trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/common/scripte=
nv.cpp 1182146 =

  /trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/plasmoid/simpl=
ejavascriptapplet.h 1182146 =

  /trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/plasmoid/simpl=
ejavascriptapplet.cpp 1182146 =

Diff: http://svn.reviewboard.kde.org/r/5526/diff

Testing
-------

I wrote a little test-plasmoid.
You can get it here (I'll probably commit a polished version of that to kde=
examples at some point):
http://filebin.ca/abcwza/codedefault.tar.bz2

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5526/">http://svn.reviewboard.kde.org/r/5526/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Blumenstingl.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds support for evaluating code statements in the JavaScript \
Engine. Please note that this depends on http://svn.reviewboard.kde.org/r/5525/

If this one gets approved I&#39;ll start working on the other engines.
I hope porting this to other engines is possible.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wrote a little test-plasmoid. You can get it here (I&#39;ll probably \
commit a polished version of that to kdeexamples at some point): \
http://filebin.ca/abcwza/codedefault.tar.bz2</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/common/scriptenv.h \
<span style="color: grey">(1182146)</span></li>

 <li>/trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/common/scriptenv.cpp \
<span style="color: grey">(1182146)</span></li>

 <li>/trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/plasmoid/simplejavascriptapplet.h \
<span style="color: grey">(1182146)</span></li>

 <li>/trunk/KDE/kdebase/runtime/plasma/scriptengines/javascript/plasmoid/simplejavascriptapplet.cpp \
<span style="color: grey">(1182146)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5526/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 