'Re: Review Request: Do not use tree view for categories in the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Do not use tree view for categories in the
From:       "Anselmo L. S. Melo" <anselmo.melo () openbossa ! org>
Date:       2010-10-02 15:11:56
Message-ID: 20101002151156.30761.82521 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-10-01 17:20:56, Aaron Seigo wrote:
> > much nicer.

Commited in r1181683. Thanks.

- Anselmo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5446/#review7929
-----------------------------------------------------------

On 2010-09-27 10:57:33, Anselmo L. S. Melo wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5446/
> -----------------------------------------------------------
> =

> (Updated 2010-09-27 10:57:33)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> The propose here is to remove the Tree View used in the widgets explorer =
in vertical orientation. In its place, use the same button of the horizonta=
l orientation, what simplifies the code (removes a class and some checks) a=
nd improves the use of space as the widgets list can grow vertically.
> =

> Better if combined with http://reviewboard.kde.org/r/4676/ as we also gai=
n the space currently occupied by the arrow buttons and the close button in=
 the bottom left corner.
> =

> The screenshots attached show the current widget explorer with the catego=
ries tree view and the proposed one, using the categories button.
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap=
pletsfiltering.h 1179288 =

>   /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/ap=
pletsfiltering.cpp 1179288 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5446/diff
> =

> =

> Testing
> -------
> =

> Tested in both horizontal and vertical orientations.
> =

> =

> Screenshots
> -----------
> =

> current widgets explorer
>   http://svn.reviewboard.kde.org/r/5446/s/511/
> proposed, not using the tree view
>   http://svn.reviewboard.kde.org/r/5446/s/512/
> =

> =

> Thanks,
> =

> Anselmo
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5446/">http://svn.reviewboard.kde.org/r/5446/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 1st, 2010, 5:20 p.m., <b>Aaron \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">much nicer.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commited in r1181683. \
Thanks.</pre> <br />

<p>- Anselmo</p>

<br />
<p>On September 27th, 2010, 10:57 a.m., Anselmo L. S. Melo wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anselmo L. S. Melo.</div>

<p style="color: grey;"><i>Updated 2010-09-27 10:57:33</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The propose here is to remove the Tree View used in the widgets explorer \
in vertical orientation. In its place, use the same button of the horizontal \
orientation, what simplifies the code (removes a class and some checks) and improves \
the use of space as the widgets list can grow vertically.

Better if combined with http://reviewboard.kde.org/r/4676/ as we also gain the space \
currently occupied by the arrow buttons and the close button in the bottom left \
corner.

The screenshots attached show the current widget explorer with the categories tree \
view and the proposed one, using the categories button.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in both horizontal and vertical orientations.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.h \
<span style="color: grey">(1179288)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp \
<span style="color: grey">(1179288)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5446/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/5446/s/511/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/25/widgetexplorer-current_400x100.png" \
style="border: 1px black solid;" alt="current widgets explorer" /></a>

 <a href="http://svn.reviewboard.kde.org/r/5446/s/512/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/25/widgetexplorer-proposed_400x100.png" \
style="border: 1px black solid;" alt="proposed, not using the tree view" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 