[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Optional passive calendar popup for the Digital
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-10-02 2:25:04
Message-ID: 20101002022504.14664.79772 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5513/#review7934
-----------------------------------------------------------
as discussed earlier today on irc, and for all the reasons discussed there,=
this is not a change we want or care to have. it's one more code path that=
will end up being maintained by yours truly in the future. sorry.
you are completely welcome to maintain this as a separate plasmoid or as a =
patch to the source, of course.
"The only downside is that you either have to relog or somehow reload that =
digital-clock plasmoid when you change the "passivePopup" value."
that's probably because you need to read the value in configChanged().
/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp
<http://svn.reviewboard.kde.org/r/5513/#comment8183>
i don't see why the behaviour should be different in other form factors=
. *shrug*
- Aaron
On 2010-10-02 02:05:02, Mark wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5513/
> -----------------------------------------------------------
> =
> (Updated 2010-10-02 02:05:02)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> I know some people don't like this idea thus the default is the same as i=
t's right now.
> I want to make the calendar passive popup optional since some people like=
it that way (me included).
> =
> OK to commit?
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1181669 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock=
.cpp 1181669 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5513/diff
> =
> =
> Testing
> -------
> =
> Tested it a few times with true and false and seems to work just fine.
> The only downside is that you either have to relog or somehow reload that=
digital-clock plasmoid when you change the "passivePopup" value.
> =
> =
> Thanks,
> =
> Mark
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5513/">http://svn.reviewboard.kde.org/r/5513/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as discussed earlier \
today on irc, and for all the reasons discussed there, this is not a change we want \
or care to have. it's one more code path that will end up being maintained by \
yours truly in the future. sorry.
you are completely welcome to maintain this as a separate plasmoid or as a patch to \
the source, of course.
"The only downside is that you either have to relog or somehow reload that \
digital-clock plasmoid when you change the "passivePopup" value."
that's probably because you need to read the value in configChanged().</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5513/diff/1/?file=38824#file38824line592" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ClockApplet::popupEvent(bool show)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">592</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">constraints</span> <span \
class="o">&</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="n">FormFactorConstraint</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">593</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setPassivePopup</span><span class="p">(</span><span \
class="n">formFactor</span><span class="p">()</span> <span class="o">==</span> <span \
class="n">Plasma</span><span class="o">::</span><span class="n">Horizontal</span> \
<span class="o">||</span> <span class="n">formFactor</span><span class="p">()</span> \
<span class="o">==</span> <span class="n">Plasma</span><span class="o">::</span><span \
class="n">Vertical</span><span class="p">);</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">594</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i don't \
see why the behaviour should be different in other form factors. *shrug*</pre> </div>
<br />
<p>- Aaron</p>
<br />
<p>On October 2nd, 2010, 2:05 a.m., Mark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mark.</div>
<p style="color: grey;"><i>Updated 2010-10-02 02:05:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I know some people don't like this idea thus the default is the same \
as it's right now. I want to make the calendar passive popup optional since some \
people like it that way (me included).
OK to commit?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it a few times with true and false and seems to work just fine. \
The only downside is that you either have to relog or somehow reload that \
digital-clock plasmoid when you change the "passivePopup" value.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp <span \
style="color: grey">(1181669)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp \
<span style="color: grey">(1181669)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5513/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic