[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: use sqlite for storage
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-10-01 17:58:07
Message-ID: 20101001175807.4345.39470 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-01 17:13:46, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/private/storage.cpp, line 41
> > <http://svn.reviewboard.kde.org/r/5506/diff/1/?file=38787#file38787line41>
> >
> > instead of an incrementing connectionId, you could also use the value of the this \
> > pointer? one less static int kicking around.
uhm, i tought using a pointer value was even uglier, but ok.
another thing that i tought seeing it. is really necessary having a different \
connection per job, since the query execution is afaik syncronous? even tought aboout \
a little singleton that holds a single QSqlDatabase...
> On 2010-10-01 17:13:46, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/private/storage.cpp, lines 46-49
> > <http://svn.reviewboard.kde.org/r/5506/diff/1/?file=38787#file38787line46>
> >
> > destination() is no longer used; with one db file used for all the storage, we \
> > end up with all the data in one db with no separation.
> > it would make sense to me here to create a table for each destination().
> >
> > on applet destruction, it could drop its table (if any).
> >
> > on applet export, it could pull its table over to an exported db. (i imagine that \
> > Corona would use this in its export method).
or, destination could be a field (with key,destination being the primary key) would \
be ugly, but easier to expire old entries but yeah, i like more the different tbles \
approach in general also, if this is going to be used by applets, the source field \
doesn't make sense here...
> On 2010-10-01 17:13:46, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/private/storage.cpp, line 66
> > <http://svn.reviewboard.kde.org/r/5506/diff/1/?file=38787#file38787line66>
> >
> > ah, sql databases.
> >
> > this query will result in multiple rows with the same key, and when requested \
> > back you'll end up with a random row.
> > to fix this, first delete the old row. or check if the old row exists and do an \
> > update instead of an insert. and no, there is no "update or insert" in sql. \
> > that's what sorted procedures are for ;P
uhm, i think even worse, since key is primary the inseret should just silently fail, \
so the old stale entry wins i think i'll just try to delete the line before.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5506/#review7926
-----------------------------------------------------------
On 2010-10-01 15:05:11, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5506/
> -----------------------------------------------------------
>
> (Updated 2010-10-01 15:05:11)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> looking at how slow kconfig as, this makes storage use sqlite (and makes some \
> methods private, before it's too late) it can still use some improvements but it's \
> basically working. two main concerns are:
> - is acceptable/safe to link to QtSql and assume the sqlite driver is present?
> - i would still see this as a fallback for when an akonadi version is not present \
> (being in another process should slowdown the gui a bit less, but i could not want \
> it in some mobile profiles)
> the akonadi version is in the usual status "almost working with developer \
> disappeared" :p
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1179394
> /trunk/KDE/kdelibs/plasma/datacontainer.h 1179394
> /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1179394
> /trunk/KDE/kdelibs/plasma/dataengine.cpp 1179394
> /trunk/KDE/kdelibs/plasma/private/datacontainer_p.h 1179394
> /trunk/KDE/kdelibs/plasma/private/storage.cpp 1179394
> /trunk/KDE/kdelibs/plasma/private/storage_p.h 1179394
>
> Diff: http://svn.reviewboard.kde.org/r/5506/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5506/">http://svn.reviewboard.kde.org/r/5506/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2010, 5:13 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5506/diff/1/?file=38787#file38787line41" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/private/storage.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">41</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_db</span> <span class="o">=</span> <span \
class="n">QSqlDatabase</span><span class="o">::</span><span \
class="n">addDatabase</span><span class="p">(</span><span \
class="s">"QSQLITE"</span><span class="p">,</span> <span \
class="n">QString</span><span class="p">(</span><span \
class="s">"plasma-storage-%1"</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span class="o">++</span><span \
class="n">connectionId</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">instead of an \
incrementing connectionId, you could also use the value of the this pointer? one less \
static int kicking around.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm, i \
tought using a pointer value was even uglier, but ok. another thing that i tought \
seeing it. is really necessary having a different connection per job, since the query \
execution is afaik syncronous? even tought aboout a little singleton that holds a \
single QSqlDatabase...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2010, 5:13 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5506/diff/1/?file=38787#file38787line46" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/private/storage.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span class="n">m_db</span><span \
class="p">.</span><span class="n">tables</span><span class="p">().</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">"data"</span><span class="p">))</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QSqlQuery</span> <span class="n">query</span><span class="p">(</span><span \
class="n">m_db</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">query</span><span class="p">.</span><span class="n">exec</span><span \
class="p">(</span><span class="s">"create table data (id varchar(100) primary \
key, source varchar(100), data clob, date datetime)"</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">destination() is no \
longer used; with one db file used for all the storage, we end up with all the data \
in one db with no separation.
it would make sense to me here to create a table for each destination().
on applet destruction, it could drop its table (if any).
on applet export, it could pull its table over to an exported db. (i imagine that \
Corona would use this in its export method).</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">or, \
destination could be a field (with key,destination being the primary key) would be \
ugly, but easier to expire old entries but yeah, i like more the different tbles \
approach in general also, if this is going to be used by applets, the source field \
doesn't make sense here...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2010, 5:13 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5506/diff/1/?file=38787#file38787line66" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/KDE/kdelibs/plasma/private/storage.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">43</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setResult</span><span class="p">(</span><span class="kc">true</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">62</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">query</span><span \
class="p">.</span><span class="n">prepare</span><span class="p">(</span><span \
class="s">"insert into data values(:id, :source, :datavalue, \
'now')"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, sql databases.
this query will result in multiple rows with the same key, and when requested back \
you'll end up with a random row.
to fix this, first delete the old row. or check if the old row exists and do an \
update instead of an insert. and no, there is no "update or insert" in sql. \
that's what sorted procedures are for ;P</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm, i \
think even worse, since key is primary the inseret should just silently fail, so the \
old stale entry wins i think i'll just try to delete the line before.</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 1st, 2010, 3:05 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-10-01 15:05:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looking at how slow kconfig as, this makes storage use sqlite (and makes \
some methods private, before it's too late) it can still use some improvements \
but it's basically working. two main concerns are:
- is acceptable/safe to link to QtSql and assume the sqlite driver is present?
- i would still see this as a fallback for when an akonadi version is not present \
(being in another process should slowdown the gui a bit less, but i could not want it \
in some mobile profiles)
the akonadi version is in the usual status "almost working with developer \
disappeared" :p</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/datacontainer.h <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/datacontainer.cpp <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/dataengine.cpp <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/datacontainer_p.h <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/storage.cpp <span style="color: \
grey">(1179394)</span></li>
<li>/trunk/KDE/kdelibs/plasma/private/storage_p.h <span style="color: \
grey">(1179394)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5506/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic