[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: allow SVGs to use systemcolors
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-10-01 14:54:41
Message-ID: 20101001145441.31487.21051 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5495/#review7925
-----------------------------------------------------------
Ship it!
i think it's pretty good now
- Marco
On 2010-10-01 14:25:03, Manuel Mommertz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5495/
> -----------------------------------------------------------
> =
> (Updated 2010-10-01 14:25:03)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> With this patch applied SVGs can put a style-element with id 'current-sys=
tem-colors' in it, which gets replaced by a style with the current systemco=
lors. This allows SVGs to use colors like background color and text color f=
rom the system palette. Giving themes much more possibilitys then just colo=
ring the resulting pixmap.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/theme.h 1180314 =
> /trunk/KDE/kdelibs/plasma/theme.cpp 1180314 =
> /trunk/KDE/kdelibs/plasma/svg.cpp 1180314 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5495/diff
> =
> =
> Testing
> -------
> =
> Changing theme, changing colorscheme
> =
> =
> Screenshots
> -----------
> =
> Default Colorscheme
> http://svn.reviewboard.kde.org/r/5495/s/520/
> green-gray Colorscheme
> http://svn.reviewboard.kde.org/r/5495/s/522/
> =
> =
> Thanks,
> =
> Manuel
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5495/">http://svn.reviewboard.kde.org/r/5495/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think it's pretty \
good now</pre> <br />
<p>- Marco</p>
<br />
<p>On October 1st, 2010, 2:25 p.m., Manuel Mommertz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Manuel Mommertz.</div>
<p style="color: grey;"><i>Updated 2010-10-01 14:25:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch applied SVGs can put a style-element with id \
'current-system-colors' in it, which gets replaced by a style with the \
current systemcolors. This allows SVGs to use colors like background color and text \
color from the system palette. Giving themes much more possibilitys then just \
coloring the resulting pixmap.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changing theme, changing colorscheme</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/theme.h <span style="color: \
grey">(1180314)</span></li>
<li>/trunk/KDE/kdelibs/plasma/theme.cpp <span style="color: \
grey">(1180314)</span></li>
<li>/trunk/KDE/kdelibs/plasma/svg.cpp <span style="color: \
grey">(1180314)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5495/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5495/s/520/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/01/plasmadesktopno7128_400x100.png" \
style="border: 1px black solid;" alt="Default Colorscheme" /></a>
<a href="http://svn.reviewboard.kde.org/r/5495/s/522/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/01/plasmadesktopvj7128_400x100.png" \
style="border: 1px black solid;" alt="green-gray Colorscheme" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic