[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Make kolourpicker color grab working from autohiding
From: Björn_Ruberg <bjoern () ruberg-wegener ! de>
Date: 2010-09-28 10:01:19
Message-ID: 20100928100119.17724.92472 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5465/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Patch fixes the bug that the mouse grab of the color-picker goes away when the panel \
hides. The idea of initiating the grab not on the panel but on a self created widget \
is from ksnapshot. I want someone to look at it because I want to commit it KDE 4.5 \
branch as a bugfix.
This addresses bug 252350.
https://bugs.kde.org/show_bug.cgi?id=252350
Diffs
-----
/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h 1180054
/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1180054
Diff: http://svn.reviewboard.kde.org/r/5465/diff
Testing
-------
Had kolourpicker in an autohiding panel - and it suddenly works. Tested with an \
applet on the desktop too. Works.
Thanks,
Björn
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5465/">http://svn.reviewboard.kde.org/r/5465/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Björn Ruberg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch fixes the bug that the mouse grab of the color-picker goes away \
when the panel hides. The idea of initiating the grab not on the panel but on a self \
created widget is from ksnapshot. I want someone to look at it because I want to \
commit it KDE 4.5 branch as a bugfix.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Had kolourpicker in an autohiding panel - and it suddenly works. Tested \
with an applet on the desktop too. Works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=252350">252350</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h <span \
style="color: grey">(1180054)</span></li>
<li>/trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp <span \
style="color: grey">(1180054)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5465/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic