[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: render SVGs with system colors
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-09-27 21:09:16
Message-ID: 201009271409.17441.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday, September 27, 2010, Manuel Mommertz wrote:
> So would do you think of this? Should we try to get something like this in
> libplasma? Or is it to exotic? Maybe someone even has an idea how we can
> archive this in a clean way. Let me know. :)

i think the idea is good, and the overhead should be acceptable for the svg's 
that use it. the file will only be read once, the expensive bit will be the 
xml parsing being done twice.

the skel can be cached as well, created on first use and then kept around 
until the theme changes.

have you done any timings to test how long the DOM parsing takes on svgs we 
have in the theme?

(i'd also recommend putting the patch on reviewboard where it is easier to go 
through these kinds of things.)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]