[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Corona::exportLayout
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-09-27 16:53:31
Message-ID: 20100927165331.32485.42890 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5451/#review7839
-----------------------------------------------------------
Ship it!
a few small things, but this can go in with the details fixed :)
trunk/KDE/kdelibs/plasma/corona.h
<http://svn.reviewboard.kde.org/r/5451/#comment8108>
should be marked with KDE_DEPRECATED to generate compiler warnings.
trunk/KDE/kdelibs/plasma/corona.h
<http://svn.reviewboard.kde.org/r/5451/#comment8109>
KConfigGroup &config, same as elsewhere in the libplasma API.
trunk/KDE/kdelibs/plasma/corona.cpp
<http://svn.reviewboard.kde.org/r/5451/#comment8110>
right now importLayout(const KConfigBase &conf) checks to make sure tha=
t the KConfigGroup isValid(); this check should be moved to CoronaPrivate::=
importLayout so it can be shared with both importLayout methods.
- Aaron
On 2010-09-27 14:38:42, Chani Armitage wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5451/
> -----------------------------------------------------------
> =
> (Updated 2010-09-27 14:38:42)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> this adds exportLayout to corona, which saves a group of containments to =
a config file and deletes them from the main config.
> =
> Activity::close() becomes a lot shorter by calling it, like this: m_coron=
a->exportLayout(external, m_containments.values());
> =
> I feel a bit out of it today though, so tell me if I've missed anything o=
bvious...
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/plasma/corona.h 1179499 =
> trunk/KDE/kdelibs/plasma/corona.cpp 1179499 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5451/diff
> =
> =
> Testing
> -------
> =
> closing an activity while locked is perfectly safe now :)
> =
> =
> Thanks,
> =
> Chani
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5451/">http://svn.reviewboard.kde.org/r/5451/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a few small things, but \
this can go in with the details fixed :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5451/diff/2/?file=38573#file38573line264" style="color: black; font-weight: \
bold; text-decoration: underline;">trunk/KDE/kdelibs/plasma/corona.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">263</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QList</span><span class="o"><</span><span class="n">Plasma</span><span \
class="o">::</span><span class="n">Containment</span> <span class="o">*></span> \
<span class="n">importLayout</span><span class="p">(</span><span \
class="k">const</span> <span class="n">KConfigBase</span> <span \
class="o">&</span><span class="n">config</span><span \
class="p">);</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">264</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span \
class="o"><</span><span class="n">Plasma</span><span class="o">::</span><span \
class="n">Containment</span> <span class="o">*></span> <span \
class="n">importLayout</span><span class="p">(</span><span class="k">const</span> \
<span class="n">KConfigBase</span> <span class="o">&</span><span \
class="n">config</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
marked with KDE_DEPRECATED to generate compiler warnings.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5451/diff/2/?file=38573#file38573line293" style="color: black; font-weight: \
bold; text-decoration: underline;">trunk/KDE/kdelibs/plasma/corona.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">293</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">exportLayout</span><span \
class="p">(</span><span class="n">KConfigGroup</span> <span class="o">*</span><span \
class="n">config</span><span class="p">,</span> <span class="n">QList</span><span \
class="o"><</span><span class="n">Containment</span><span class="o">*></span> \
<span class="n">containments</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KConfigGroup &config, same as elsewhere in the libplasma API.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5451/diff/2/?file=38574#file38574line497" style="color: black; font-weight: \
bold; text-decoration: underline;">trunk/KDE/kdelibs/plasma/corona.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">QList<Plasma::Containment *> Corona::importLayout(const KConfigGroup \
&conf)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">497</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">d</span><span class="o">-></span><span \
class="n">importLayout</span><span class="p">(</span><span class="n">conf</span><span \
class="p">,</span> <span class="kc">true</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">right now \
importLayout(const KConfigBase &conf) checks to make sure that the KConfigGroup \
isValid(); this check should be moved to CoronaPrivate::importLayout so it can be \
shared with both importLayout methods.</pre> </div>
<br />
<p>- Aaron</p>
<br />
<p>On September 27th, 2010, 2:38 p.m., Chani Armitage wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Chani Armitage.</div>
<p style="color: grey;"><i>Updated 2010-09-27 14:38:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this adds exportLayout to corona, which saves a group of containments to \
a config file and deletes them from the main config.
Activity::close() becomes a lot shorter by calling it, like this: \
m_corona->exportLayout(external, m_containments.values());
I feel a bit out of it today though, so tell me if I've missed anything \
obvious...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">closing an activity while locked is perfectly safe now :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/corona.h <span style="color: \
grey">(1179499)</span></li>
<li>trunk/KDE/kdelibs/plasma/corona.cpp <span style="color: \
grey">(1179499)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5451/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic