--===============0433966533== Content-Type: multipart/alternative; boundary="===============1043526670688062372==" --===============1043526670688062372== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5355/#review7825 ----------------------------------------------------------- Ship it! - Aaron On 2010-09-24 23:59:14, Anthony Bryant wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5355/ > ----------------------------------------------------------- > = > (Updated 2010-09-24 23:59:14) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > * Make configAccepted() just write the new config, and make configChanged= () conditionally update the plasmoid after reading the config back in. > * Split the grid resizing logic into its own method: recalculateGridSizes= (int rows), and make it detect more edge cases. > * Rename the main size calculation method to updateSizes(bool allowResize= ), which will resize the applet to its preferred size if allowResize is tru= e. > * Fix a bug which caused applet resizes to be wrongly cancelled in some s= ituations. > * Code style cleanups, remove unused variables, etc. > = > (Sorry for putting so many changes into one patch) > = > = > This addresses bug 250756. > https://bugs.kde.org/show_bug.cgi?id=3D250756 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.h 11792= 62 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 117= 9262 = > = > Diff: http://svn.reviewboard.kde.org/r/5355/diff > = > = > Testing > ------- > = > Tested configuring the pager from the config interface and the desktop co= nsole, and that it responds correctly to changes in desktop count, and in F= ormFactor and size. > = > = > Thanks, > = > Anthony > = > --===============1043526670688062372== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5355/ |
Ship it!
- Aaron
On September 24th, 2010, 11:59 p.m., Anthony Bryant wrote:
Review request for Plasma.
By Anthony Bryant.
Updated 2010-09-24 23:59:14 Descripti= on
Testing <= /h1>
Bugs:
250756
Diffs=
|